Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reimplement '--no-sort' to be compatible with Terraform 0.12 configuration #141

Merged
merged 1 commit into from
Jan 3, 2020

Conversation

khos2ow
Copy link
Member

@khos2ow khos2ow commented Jan 3, 2020

Prerequisites

Put an x into the box(es) that apply:

  • This pull request fixes a bug.
  • This pull request adds a feature.
  • This pull request enhances existing functionality.
  • This pull request introduces breaking change.

For more information, see the Contributing Guide.

Description

While adding the support for Terraform 0.12 configuration in #113 we lost support for --no-sort functionality, this PR fixes that and adds it back and also removes the temporary hack we had to do for tests to not constantly failing.

Issues Resolved

List any existing issues this pull request resolves.

Checklist

Put an x into all boxes that apply:

Tests

  • I have added tests to cover my changes.
  • All tests pass when I run make test.

Documentation

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

Code Style

  • My code follows the code style of this project.

@khos2ow khos2ow changed the title Re-implement '--no-sort' to be compatible with Terraform 0.12 configuration Reimplement '--no-sort' to be compatible with Terraform 0.12 configuration Jan 3, 2020
@khos2ow khos2ow merged commit 80978e9 into terraform-docs:master Jan 3, 2020
@khos2ow khos2ow deleted the no-sort branch January 3, 2020 02:16
@khos2ow khos2ow added this to the v0.8.0 milestone Jan 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant