Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show all JSON properties, empty or null #160

Merged
merged 2 commits into from
Jan 14, 2020

Conversation

khos2ow
Copy link
Member

@khos2ow khos2ow commented Jan 14, 2020

Prerequisites

Put an x into the box(es) that apply:

  • This pull request fixes a bug.
  • This pull request adds a feature.
  • This pull request enhances existing functionality.
  • This pull request introduces breaking change.

For more information, see the Contributing Guide.

Description

JSON properties which are nil were dropped from being rendered instead of being shown as key: "" or key: null. This PR fixes that. If properties are not defined one of the following can happen:

  • type: "" (in reality never should happen though)
  • description: ""
  • default: null

Issues Resolved

Fixes #158

Checklist

Put an x into all boxes that apply:

Tests

  • I have added tests to cover my changes.
  • All tests pass when I run make test.

Documentation

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

Code Style

  • My code follows the code style of this project.

@khos2ow khos2ow added this to the v0.8.0 milestone Jan 14, 2020
@khos2ow khos2ow merged commit 61fc16c into terraform-docs:master Jan 14, 2020
@khos2ow khos2ow deleted the default-value-null branch January 14, 2020 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

v0.8.0-rc2 -- json output doesn't add null defaults
1 participant