Do not escape any characters of a URL #170
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites
Put an
x
into the box(es) that apply:For more information, see the Contributing Guide.
Description
As part of escaping illegal Markdown characters, if there is any of them in the URL (such as
_
) they will get escaped too, which makes the URL unusable. (for examplehttps://domain.com/foo\_bar.html
is invalid URL).This PR fixes the issue with introducing
NormalizeURLs
function which get executed after escape runs to normalize URL back.Issues Resolved
Fixes #168
Checklist
Put an
x
into all boxes that apply:Tests
make test
.Documentation
Code Style