Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Component-querystring integration breaks on node.js/server-side usage #8

Open
kylehotchkiss opened this issue Apr 24, 2018 · 1 comment
Open

Component-querystring integration breaks on node.js/server-side usage #8

kylehotchkiss opened this issue Apr 24, 2018 · 1 comment

Comments

@kylehotchkiss
Copy link

component/querystring#15

The component-querystring package has a quirk that breaks the utm-params package in node.js due to how they use the browser param in package.json. Is it possible to remove this dependency in favor of Node.js built-in querystring parser?
@kylehotchkiss
Copy link
Author

My fix for this is to add this to package.json for whatever project is using utm-params:

"postinstall": "sed -i '' '7s/.*/var type = require(\"component-type\");/' node_modules/component-querystring/index.js"

@taymoork2 taymoork2 mentioned this issue Sep 15, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kylehotchkiss