Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scale filename should be the same as Dokku uses #29

Closed
srigi opened this issue Sep 11, 2015 · 2 comments
Closed

Scale filename should be the same as Dokku uses #29

srigi opened this issue Sep 11, 2015 · 2 comments

Comments

@srigi
Copy link

srigi commented Sep 11, 2015

In this Dokku issue and in sources of Dokku you can see that SCALE file was renamed to DOKKU_SCALE. This project should follow and use the same name.
@srigi srigi changed the title Scale file should be the same as Dokku uses Scale filename should be the same as Dokku uses Sep 11, 2015
@michaelshobbs
Copy link
Contributor

As this plugin and dokku core handle scaling in very different ways, I think it makes sense to not have their configuration filenames overlap.

@srigi
Copy link
Author

srigi commented Sep 12, 2015

Ah OK, I was thinking this plugins is replacing default Dokku scale mechanism.

@srigi srigi closed this as completed Sep 12, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@srigi @michaelshobbs