Let libtau thtows an exception if a source depth is negative

[luca-s]

Dear developers,

I have been thinking at this check here and I do not believe it is a good idea to hide problems. I would rather prefer the travel time table to throw an exception and let the caller decide what it is the best way to handle it. Trying to cope with a bad input is usually not the best approach for an api. It is normally better to communicate the error and let the caller address the issue in the most appropriate way since it is the caller that knows better.

What do you think?

Luca

[gempa-jabe]

Have you tried to remove that line and does everything still work? I am actually fine with removing that line and maybe @jsaul can comment on it as well.

[luca-s]

My plan is to properly test the removal if you accept to remove it :)

[luca-s]

I have been thinking again about it and it doesn't matter to change this behaviour, even though I do not like it. libtau is strongly coupled with scautoloc and I don't want to introduce unwanted behaviour in scautoloc. Thanks for considering this issue anyway.