Skip to content
This repository has been archived by the owner on Oct 1, 2020. It is now read-only.

No support for diatrics (accents in other languages) #5

Closed
floriansegginger opened this issue Nov 27, 2015 · 2 comments
Closed

No support for diatrics (accents in other languages) #5

floriansegginger opened this issue Nov 27, 2015 · 2 comments

Comments

@floriansegginger
Copy link
Contributor

Hello,

Currently, jsmegahal does not support words with accents. This is due to the regexp used to split words.

I don't know how to make pull requests, so here's how you should change it to make it work (the fix is pretty simple):

Line 18, lib/jsMegaHal.coffee
wordRegex: /[^a-zA-Z0-9,'\u00C0-\u017F]+

This will include the range of unicode characters required.

@seiyria
Copy link
Owner

seiyria commented Nov 27, 2015

Hey! Thanks for the info. I don't mind making this change, but I prefer giving credit (and the easiest way to do that is via pull requests). One way you can do it is open up the file on github and hit the edit button. There, make your changes, save, and hit the "submit pull request" button.

Just make sure your regex is valid - there, it looks like you're missing a trailing /.

@floriansegginger
Copy link
Contributor Author

Never saw that feature! Thanks, will do!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants