Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ssrHandler - cache based on params as well as route string #23

Closed
sejori opened this issue May 3, 2022 · 0 comments
Closed

ssrHandler - cache based on params as well as route string #23

sejori opened this issue May 3, 2022 · 0 comments
Assignees
@sejori
Labels
bug Something isn't working

Comments

@sejori
Copy link
Owner

sejori commented May 3, 2022 •
edited

now that params can be passed into render function caching on route string alone won't do as same route could return different content based on params from middleware
@sejori sejori added the bug Something isn't working label May 3, 2022
@sejori sejori changed the title ssrHandler should cache based on params as well as route now that they can be passed into render function ssrHandler - cache based on params as well as route string May 3, 2022
@sejori sejori self-assigned this May 5, 2022
@sejori sejori mentioned this issue May 9, 2022
Merged
@sejori sejori closed this as completed May 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sejori sejori

Labels
bug Something isn't working
Projects
No open projects
peko v0.1
Status: Done
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sejori