Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

error from you example preact : deno version 1.24.3 #43

Closed
bobwatcherx opened this issue Aug 14, 2022 · 5 comments · Fixed by #51
Closed

error from you example preact : deno version 1.24.3 #43

bobwatcherx opened this issue Aug 14, 2022 · 5 comments · Fixed by #51

Comments

@bobwatcherx
Copy link

i clone you example , but i get error
i use deno latest : Deno 1.24.3
d:\1. BELAJAR HTML\denoPRO\MAINAN\peko> deno run --allow-net --allow-env --allow-read --watch examples/preact/app.ts

and get error for Example preact folder

error message:
error: Uncaught (in promise) Error: The filename, directory name, or volume label syntax is incorrect. (os error 123), readdir '/D:/1.%20BELAJAR%20HTML/denoPRO/MAINAN/peko/examples/preact/src' for await (const dirEntry of Deno.readDir(path)) {

@sejori
Copy link
Owner

sejori commented Aug 18, 2022

What operating system are you using? Windows by any chance? There is a pathname fix in handlers/static.ts for windows which might not be doing its job properly. I haven't tested on windows in a while.

@bobwatcherx
Copy link
Author

yes I use windows, I'm waiting for the repair

@nhrones
Copy link

nhrones commented Aug 18, 2022

Same here Windows10.
Can't run any example...

> deno run --allow-net --allow-env --allow-read --watch examples/preact/app.ts
Watcher Process started.
error: Uncaught (in promise) Error: The filename, directory name, or volume label syntax is incorrect. (os error 123), readdir '/C:/Users/nhron/Desktop/peko/examples/preact/src'
    for await (const dirEntry of Deno.readDir(path)) {
                     ^
    at async Object.[Symbol.asyncIterator] (deno:runtime/js/30_fs.js:126:16)
    at async getFiles (https://deno.land/x/recursive_readdir@v2.0.0/mod.ts:9:22)
    at async recursiveReaddir (https://deno.land/x/recursive_readdir@v2.0.0/mod.ts:17:3)        
    at async file:///C:/Users/nhron/Desktop/peko/examples/preact/routes.ts:98:3
Watcher Process finished. Restarting on file change...

@tamo
Copy link
Contributor

tamo commented Aug 23, 2022

This may help you: denoland/deno#14605

@sejori
Copy link
Owner

sejori commented Aug 23, 2022

Amazing! Thank you for such a nice fix. I will go through and apply to the other examples soon 👏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants