Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Php 8.3 compatibility issue #1897

Closed
pratik8787 opened this issue Jun 20, 2024 · 5 comments
Closed

Php 8.3 compatibility issue #1897

pratik8787 opened this issue Jun 20, 2024 · 5 comments
Labels

Comments

@pratik8787
Copy link

Monolog 3.6.0

While checking the php compatibility via codesniffer for PHP 8.3, it is giving these errors for Monolog library

116 | ERROR | "$this" can no longer be used in a plain function or method since PHP 7.1.
121 | ERROR | "$this" can no longer be used in a plain function or method since PHP 7.1.
126 | ERROR | "$this" can no longer be used in a plain function or method since PHP 7.1.
138 | ERROR | "$this" can no longer be used in a plain function or method since PHP 7.1.
157 | ERROR | "$this" can no longer be used in a plain function or method since PHP 7.1.
176 | ERROR | "$this" can no longer be used in a plain function or method since PHP 7.1.

@pratik8787 pratik8787 added the Bug label Jun 20, 2024
@Seldaek
Copy link
Owner

Seldaek commented Jun 28, 2024

In which file?!

@Seldaek
Copy link
Owner

Seldaek commented Jun 28, 2024

Ah that looks to be in Monolog\Level.. I guess this is a bug in php-codesniffer because it's an enum and not a class? Anyway nothing wrong here IMO

@Seldaek Seldaek closed this as not planned Won't fix, can't repro, duplicate, stale Jun 28, 2024
@Seldaek
Copy link
Owner

Seldaek commented Jun 28, 2024

See squizlabs/PHP_CodeSniffer#3827 - make sure you update your tooling if you are using the latest PHP version.

@golliholzland
Copy link

@Seldaek I'm having trouble understanding the situation. Has the issue been resolved, or is there still a problem? Are you implying that there might be an issue with the configuration? Please provide a clear solution or a well-constructed response before closing tickets.

@Seldaek
Copy link
Owner

Seldaek commented Jun 28, 2024

There is no problem at all. Please read the linked issue before complaining. This was never a problem with Monolog.

I'll paste it here though:

I happen to know this has already been fixed in the PHPCompatibility develop branch.

This bug was fixed over a year ago in the PHPCompatibility project. So you need to update that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants