Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add kubebuilder mark for seldondeployments/finalizers #23

Open
tmckayus opened this issue Jul 3, 2019 · 2 comments
Open

Add kubebuilder mark for seldondeployments/finalizers #23

tmckayus opened this issue Jul 3, 2019 · 2 comments

Comments

@tmckayus
Copy link
Contributor

tmckayus commented Jul 3, 2019

Based on running the seldon operator in openshift in operator-framework/community-operators#447, it looks like the operator should have a kubebuilder mark for permissions on seldondeployments/finalizers

The CSV file for the community operator was updated and contains '*' for verbs, but get, update, and patch appear to be what's needed.

@ukclivecox
Copy link
Contributor

The related PR looks good. But can you expand on why this is needed. Does the manager add finalizers? If so why does it work ok under vanilla k8s and not openshift?
Thanks.

@tmckayus
Copy link
Contributor Author

tmckayus commented Jul 5, 2019

@cliveseldon not sure about the difference between k8s and openshift, that is something to investigate. On openshift I get the following error without the change:

"deployments.apps "test-deployment-example-7cd068f" is forbidden: cannot set blockOwnerDeletion if an ownerReference refers to a resource you can't set finalizers on"

This occurs when the deployment created by the seldondeployment tries to create its ownerReference section with "blockOwnerDeletion: true"

I'll try to track down specifcs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants