Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't set font-family #50

Closed
amastaneh opened this issue Aug 3, 2016 · 5 comments
Closed

Don't set font-family #50

amastaneh opened this issue Aug 3, 2016 · 5 comments
Milestone

Comments

@amastaneh
Copy link

I think it's not recommended and it's not required that change font-family of select item because

  • select2.css has not change any font-family
  • Make conflict with default font of project
  • Consume time and bandwidth a little
@amastaneh amastaneh changed the title font-family Problem font-family Confilict Aug 3, 2016
@kevin-brown
Copy link
Member

The font-family which appears to be used is the same as the default $font-family value set by Bootstrap, which you should be able to override in the LESS or SASS files.

Consume time and bandwidth a little

Time? Sure, changing the line where it sets the font-family.
Bandwidth?

@fk
Copy link
Member

fk commented Aug 28, 2016

@kevin-brown I might not see the forest for the trees right now, but I think @amastaneh is right – select2-bootstrap-theme should just inherit font-family instead of defining its own, just like the Select2 default themes do (most probably for the exact same reasons mentioned).

@fk fk modified the milestones: 0.1.0-beta.8, 0.1.0-beta.9 Aug 28, 2016
@kevin-brown
Copy link
Member

You're right, one thing I forgot about this is that most people using Bootstrap are using the compiled files and not the source files - so the Bootstrap variable we use for the font family is never actually being changed. Considering that, it makes sense to not override the font family on our side.

@fk fk changed the title font-family Confilict Don't set font-family Aug 30, 2016
@fk fk changed the title Don't set font-family Don't set font-family Aug 30, 2016
@fk
Copy link
Member

fk commented Aug 30, 2016

@kevin-brown 👍 - will be taken care of in the next release.

@fk
Copy link
Member

fk commented Aug 31, 2016

Fixed in 0.1.0-beta.9.

@fk fk closed this as completed Aug 31, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants