-
-
Notifications
You must be signed in to change notification settings - Fork 6.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
no search icon after click in the drop-down box #4629
Comments
I miss this feature too. The magnifying glass image and the CSS to display it seem to be missing from all the v4 themes. My workaround was to lift select2.png and select2x2.png from the v3 files and insert the following CSS into my application: .select2-container--default .select2-search--dropdown .select2-search__field {
background: url(select2.png) right top no-repeat;
background-position: right -22px;
}
@media only screen and (-webkit-min-device-pixel-ratio: 1.5), only screen and (min-resolution: 2dppx) {
.select2-container--default .select2-search--dropdown .select2-search__field {
background-image: url(select2x2.png);
background-repeat: no-repeat;
background-size: 60px 40px;
background-position: 100% -21px;
}
} I notice that some people have made their own themes that put the icon back. For example, this Yii2 integration: |
We don't have immediate plans to provide this. We are focused now to fix UI bugs. But if you open a PR with unit tests, I will be glad to review and approve if everything is ok. |
OK, I gather from your response then that this feature wasn't deliberately removed in V4, but that it isn't sufficiently important for the core developers to spend any time on this, other than code review. Shall I open a PR that adds the missing code to _dropdown.scss? Assuming that no JS needs changing, I assume unit tests wouldn't be applicable. |
@rohanc Thanks for feedback! Yeah, please, open a PR with this missing code in CSS (and link this issue there). Then I can merge it into develop branch 👍 |
Prerequisites
Steps to reproduce the issue
css class:
Isolating the problem
Select2 3.5.3
http://select2.github.io/select2/index.html
image removed:
http://select2.github.io/select2/select2-3.5.3/select2.png
version 4
https://select2.github.io/examples.html
The text was updated successfully, but these errors were encountered: