Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

data-minimum-input-length and data-ajax--url do not work. #5180

Closed
tetranz opened this issue Dec 27, 2017 · 14 comments · Fixed by #5486
Closed

data-minimum-input-length and data-ajax--url do not work. #5180

tetranz opened this issue Dec 27, 2017 · 14 comments · Fixed by #5486
Milestone

Comments

@tetranz
Copy link

tetranz commented Dec 27, 2017

This is probably a partial duplicate of #5169 and the associated fixes mentioned there but it seems to be more too.

With 4.0.6-rc.0 I am unable to specify ajax url and minimum input length using data-* attributes.
This does not work: http://jsbin.com/lazabud/edit?html,output

It works when I move the options to the function call. I think #5169 covers the ajax url but not the minimum input length.

This still doesn't work properly: http://jsbin.com/vuleyoq/edit?html,output
It executes the query immediately before I enter any text.

This works correctly: http://jsbin.com/zupeki/edit?html,output

These all work with 4.0.5.

@alexweissman
Copy link
Contributor

@NadeemAfana can you take a look at this?

@alexweissman alexweissman added this to the 4.0.6 milestone Dec 27, 2017
@NadeemAfana
Copy link

Yes, this is a duplicate of #5169.

@alexweissman
Copy link
Contributor

Ah ok. So does #5169 fix the minimum input length as well?

@NadeemAfana
Copy link

Yes, it should. Let me know if you see any issue with that.

@tetranz
Copy link
Author

tetranz commented Dec 28, 2017

ok, thanks for looking at this although I'm a little confused. 5169 just changes one line of code related to the url. Utils.StoreData($e[0], 'ajax--url', Utils.GetData($e[0], 'ajaxUrl'));

I don't see how that does anything with the minimum length. 4.0.5 is working fine for me so I'll take another look when that is merged and recompiled.

@alexweissman
Copy link
Contributor

I'll try to put out 4.0.6-rc.2 soon.

@kl3sk
Copy link

kl3sk commented Mar 30, 2018

Hi,
Any release ready ?
The problem still exists

thx

@KODerFunk
Copy link

I experienced problems with data-allow-clear and data-placeholder.

@Ragash
Copy link

Ragash commented May 28, 2018

same problem with 4.0.11, any workaround?

@kl3sk
Copy link

kl3sk commented May 30, 2018

@Ragash the last version is 4.0.6-rc.1 where did you find 4.0.11 ?

@Ragash
Copy link

Ragash commented Jun 13, 2018

sorry my mind was wandering and i copied the Symfony version, instead the select2, lol.

i was actually under 4.06, and to resolve the bug i had to switch to 4.0.5, Rc2 didn't solved the issue at last for me

@stale
Copy link

stale bot commented Mar 13, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@chaumo
Copy link

chaumo commented Apr 3, 2019

I've updated from 4.0.5 to 4.0.6.rc1 because of other issues and now ajax search is broken
Changing to the 'old' deprecated data-ajax-url works, but new data-ajax--url doesn't :( Any update or estimate for 4.0.6?

@crabnky
Copy link

crabnky commented Apr 3, 2019

I think this is a duplicate of #5320.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

9 participants