Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Browser position #687

Merged
merged 4 commits into from Mar 20, 2018
Merged

Browser position #687

merged 4 commits into from Mar 20, 2018

Conversation

rosolko
Copy link
Collaborator

@rosolko rosolko commented Feb 1, 2018

Proposed changes

Add ability to set browser window position.

Checklist

  • Checkstyle and unit tests pass locally with my changes by running gradle check chrome htmlunit command
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@codecov-io
Copy link

codecov-io commented Feb 1, 2018

Codecov Report

Merging #687 into master will increase coverage by 0.6%.
The diff coverage is 76.92%.

Impacted file tree graph

@@            Coverage Diff             @@
##             master    #687     +/-   ##
==========================================
+ Coverage     61.19%   61.8%   +0.6%     
- Complexity      797     824     +27     
==========================================
  Files           152     154      +2     
  Lines          2817    2888     +71     
  Branches        271     284     +13     
==========================================
+ Hits           1724    1785     +61     
- Misses          987     994      +7     
- Partials        106     109      +3
Impacted Files Coverage Δ Complexity Δ
...ain/java/com/codeborne/selenide/Configuration.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...codeborne/selenide/webdriver/WebDriverFactory.java 83.58% <90.9%> (+1.43%) 14 <2> (+2) ⬆️
...a/com/codeborne/selenide/commands/SetSelected.java 94.73% <0%> (-5.27%) 9% <0%> (+5%)
...m/codeborne/selenide/proxy/FileDownloadFilter.java 94.82% <0%> (-0.42%) 18% <0%> (-4%)
...va/com/codeborne/selenide/CollectionCondition.java 0% <0%> (ø) 0% <0%> (ø) ⬇️
...com/codeborne/selenide/logevents/SimpleReport.java 100% <0%> (ø) 9% <0%> (+1%) ⬆️
...odeborne/selenide/collections/TextsInAnyOrder.java 76.47% <0%> (ø) 7% <0%> (?)
...n/java/com/codeborne/selenide/impl/HttpHelper.java 84.61% <0%> (ø) 6% <0%> (?)
...rne/selenide/impl/DownloadFileWithHttpRequest.java 80.28% <0%> (+0.55%) 13% <0%> (-2%) ⬇️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4e22566...fb3386a. Read the comment docs.

@coveralls
Copy link

coveralls commented Feb 1, 2018

Coverage Status

Coverage increased (+0.6%) to 65.582% when pulling fb3386a on rosolko:browser_position into 4e22566 on codeborne:master.


@Before
public void prepareTestData() {
Configuration.browser = WebDriverRunner.CHROME;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why only chrome? what if I would run test against firefox?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

my bad, commit test configuration. fixed.

@asolntsev asolntsev self-assigned this Mar 20, 2018
@asolntsev asolntsev added this to the 4.11 milestone Mar 20, 2018
@asolntsev asolntsev merged commit 5919dfb into selenide:master Mar 20, 2018
@rosolko rosolko deleted the browser_position branch March 20, 2018 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants