Overloaded method to either clear or not for existing driver when calling driver().use()

[privatejava]

Sometime we want not to close the current webdriver and switch between the driver then we cannot just do $.driver().use(webDriver); because it will automatically close the existing driver. So to make it easy we need an extra parameter for developer to either clear or not the existing driver before instantiating the new webdriver.

$.driver().use(webDriver,false);

[codecov]

Codecov Report

Merging #214 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@             Coverage Diff              @@
##             master     #214      +/-   ##
============================================
+ Coverage     84.38%   84.39%   +<.01%     
============================================
  Files           342      342              
  Lines          3483     3485       +2     
  Branches        277      277              
============================================
+ Hits           2939     2941       +2     
  Misses          444      444              
  Partials        100      100

Impacted Files	Coverage Δ	Complexity Δ
...eniumquery/browser/driver/SeleniumQueryDriver.java	91.17% <100%> (+0.55%)	0 <0> (-14)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8f1f24f...629b8ff. Read the comment docs.

[acdcjunior]

I like the idea, there's a real use case there. How about, instead of creating a new overloaded method, we create a different one, say:

$.driver().switch(anotherWebDriver);

And also add a note mentioning it in the .use() javadoc?

What do you think?

[privatejava]

Yes I am ok with that. I will do some checks and push the code tomorrow Thanks ⁣Sent from BlueMail ​

…

On Mar 10, 2019, 2:46 AM, at 2:46 AM, acdcjunior ***@***.***> wrote: I like the idea, there's a real use case there. How about, instead of creating a new overloaded method, we create a different one, say: ```java $.driver(). switch (anotherWebDriver); ``` And also add a note mentioning it in the `.use()` javadoc? What do you think? -- You are receiving this because you authored the thread. Reply to this email directly or view it on GitHub: #214 (comment)

[acdcjunior]

Great! Just so you know where I come from, I suggested that because flag arguments are generally frowned upon. See (just one of many sources): https://martinfowler.com/bliki/FlagArgument.html Cheers!

[privatejava]

I have changed it to switchTo since switch is keyword :)

[acdcjunior]

Thanks a lot. Sorry for the immense delay (I was hoping to find time to do many changes to release one big version, but I don't seem to find the time -- I have a newborn :).