Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The Chromium Team changed how they package drivers! #1968

Closed
mdmintz opened this issue Jul 20, 2023 · 4 comments
Closed

The Chromium Team changed how they package drivers! #1968

mdmintz opened this issue Jul 20, 2023 · 4 comments

Comments

@mdmintz
Copy link
Member

mdmintz commented Jul 20, 2023

The Chromium Team changed how they package drivers!

If you go to https://chromedriver.chromium.org/downloads you'll see that available chromedrivers stop at version 114. That's because they said this:

"If you are using Chrome version 115 or newer, please consult the Chrome for Testing availability dashboard. This page provides convenient JSON endpoints for specific ChromeDriver version downloading."

Here's what that means for SeleniumBase users: You'll need to upgrade to the latest version of SeleniumBase (at least 4.16.1) so that you get the update that keeps the gears turning. There was a fix for #1966 in the release: https://github.com/seleniumbase/SeleniumBase/releases/tag/v4.16.1

If you continue to use an earlier version of SeleniumBase, you'll see this warning message with Chrome 115: Warning: chromedriver update needed. Getting it now: at the start of every test because it keeps trying to download chromedriver 115 from the wrong location, so it gets chromedriver 114 instead, and uses that, which works. Once Chrome reaches version 116, you'll likely start seeing errors if you don't upgrade.

SeleniumBase 4.16.1 made a change so that chromedriver 114 continues to work with Chrome 115 (and above). Given the major changes to chromedriver starting in 115, such as requiring a special Chrome for Testing binary to work (see GoogleChromeLabs/chrome-for-testing#30), it seems that keeping the 114 chromedriver functional is a better plan for now. Will reevaluate after Chrome 116 comes out.

@mathiasbynens
Copy link

https://bugs.chromium.org/p/chromium/issues/detail?id=1466427

@mdmintz
Copy link
Member Author

mdmintz commented Jul 27, 2023

https://bugs.chromium.org/p/chromium/issues/detail?id=1466427#c27

"The patches have been backmerged, but no release containing them has been made yet. We hope to get a release out by the end of next week. Thank you for your patience."

Once those patches have been backmerged, it may be safe to upgrade SeleniumBase's driver manager. (In the current state, SeleniumBase is forcing chromedriver 114 via service_args=["--disable-build-check"]. Even if the browser version is 115 or higher, this configuration has been set to work properly.

@mdmintz
Copy link
Member Author

mdmintz commented Aug 3, 2023

Chromedriver 115.0.5790.170 was just released, fixing the issue mentioned above. The next SeleniumBase release will start using Chromedriver 115 for Chrome 115, instead of patching Chromedriver 114 for that.

@mdmintz
Copy link
Member Author

mdmintz commented Aug 5, 2023

Work completed in #1983 and released in 4.17.1 - https://github.com/seleniumbase/SeleniumBase/releases/tag/v4.17.1
(SeleniumBase support for Chrome-for-Testing)

@mdmintz mdmintz closed this as completed Aug 5, 2023
@mdmintz mdmintz unpinned this issue Aug 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants