Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add method: wait_for_selector(selector) #2583

Closed
mdmintz opened this issue Mar 9, 2024 · 1 comment · Fixed by #2586
Closed

Add method: wait_for_selector(selector) #2583

mdmintz opened this issue Mar 9, 2024 · 1 comment · Fixed by #2586
Assignees
@mdmintz
Labels
enhancement Making things better

Comments

@mdmintz
Copy link
Member

mdmintz commented Mar 9, 2024

Add method: wait_for_selector(selector)

Technically, this will be a duplicate of self.get_element(selector) and self.wait_for_element_present(selector), but having this will make it easier to migrate from outside frameworks (that have the method) to SeleniumBase.

(Not to be confused with wait_for_element(selector): a duplicate of wait_for_element_visible(selector), which waits for the element to be both present AND visible.)
@mdmintz mdmintz added the enhancement Making things better label Mar 9, 2024
@mdmintz mdmintz self-assigned this Mar 9, 2024
@mdmintz mdmintz mentioned this issue Mar 9, 2024
Merged
@mdmintz
Copy link
Member Author

mdmintz commented Mar 9, 2024

This was resolved in 4.24.5 - https://github.com/seleniumbase/SeleniumBase/releases/tag/v4.24.5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mdmintz mdmintz

Labels
enhancement Making things better
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

More methods and UC Mode updates seleniumbase/SeleniumBase
1 participant
@mdmintz