Skip to content

Commit

Permalink
Reduce verbosity of several logging statements from INFO to FINE. (#2260
Browse files Browse the repository at this point in the history
)

These statements become extremely verbose in busy clusters, as they appear to be
printed once for each test crossed with each node when the cluster is full. So
for my cluster which runs more than 50 nodes and regularly sees >200 tests
submitted at once, these can print tens of thousands of log lines per second,
adding up to gigabytes of logging per day.
  • Loading branch information
ekuefler authored and lukeis committed Jun 10, 2016
1 parent 44dc930 commit 1142aae
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
6 changes: 3 additions & 3 deletions java/server/src/org/openqa/grid/internal/BaseRemoteProxy.java
Original file line number Diff line number Diff line change
Expand Up @@ -330,15 +330,15 @@ public URL getRemoteHost() {
}

public TestSession getNewSession(Map<String, Object> requestedCapability) {
log.info("Trying to create a new session on node " + this);
log.fine("Trying to create a new session on node " + this);

if (!hasCapability(requestedCapability)) {
log.info("Node " + this + " has no matching capability");
log.fine("Node " + this + " has no matching capability");
return null;
}
// any slot left at all?
if (getTotalUsed() >= config.maxSession) {
log.info("Node " + this + " has no free slots");
log.fine("Node " + this + " has no free slots");
return null;
}
// any slot left for the given app ?
Expand Down
2 changes: 1 addition & 1 deletion java/server/src/org/openqa/grid/internal/ProxySet.java
Original file line number Diff line number Diff line change
Expand Up @@ -148,7 +148,7 @@ public TestSession getNewSession(Map<String, Object> desiredCapabilities) {
// test running, to avoid putting all the load of the first
// proxies.
List<RemoteProxy> sorted = getSorted();
log.info("Available nodes: " + sorted);
log.fine("Available nodes: " + sorted);

for (RemoteProxy proxy : sorted) {
TestSession session = proxy.getNewSession(desiredCapabilities);
Expand Down

0 comments on commit 1142aae

Please sign in to comment.