GeckoDriverService always launches GeckoDriver. (#2808)

GeckoDriver can find Firefox using its own logic (either on the PATH or specified in a capability).
SeleniumHQ · Sep 21, 2016 · 12d92aa · 12d92aa
1 parent 0fce43e
commit 12d92aa
Showing 1 changed file with 8 additions and 2 deletions.
diff --git a/java/client/src/org/openqa/selenium/firefox/GeckoDriverService.java b/java/client/src/org/openqa/selenium/firefox/GeckoDriverService.java
@@ -101,8 +101,14 @@ protected ImmutableList<String> createArgs() {
       if (getLogFile() != null) {
         argsBuilder.add(String.format("--log-file=\"%s\"", getLogFile().getAbsolutePath()));
       }
-      argsBuilder.add("-b");
-      argsBuilder.add(new Executable(null).getPath());
+      try {
+        Executable firefoxExe = new Executable(null);
+        argsBuilder.add("-b");
+        argsBuilder.add(firefoxExe.getPath());
+      } catch (WebDriverException e) {
+        // Unable to find Firefox. GeckoDriver will be responsible for finding 
+        // Firefox on the PATH or via a capability.
+      }
       return argsBuilder.build();
     }