Skip to content

Commit

Permalink
[Ruby] remove --disable-gpu option for headless Chrome
Browse files Browse the repository at this point in the history
  • Loading branch information
cgoldberg committed Feb 18, 2019
1 parent 97f4e20 commit 1674e14
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 7 deletions.
3 changes: 0 additions & 3 deletions rb/lib/selenium/webdriver/chrome/options.rb
Original file line number Diff line number Diff line change
Expand Up @@ -134,9 +134,6 @@ def add_preference(name, value)

def headless!
add_argument '--headless'

# https://bugs.chromium.org/p/chromium/issues/detail?id=737678#c1
add_argument '--disable-gpu' if WebDriver::Platform.windows?
end

#
Expand Down
5 changes: 1 addition & 4 deletions rb/spec/unit/selenium/webdriver/chrome/options_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -98,10 +98,7 @@ module Chrome
describe '#headless!' do
it 'should add necessary command-line arguments' do
subject.headless!
if WebDriver::Platform.windows?
expect(subject.args.to_a).to eql(%w[--headless --disable-gpu])
else
expect(subject.args.to_a).to eql(['--headless'])
expect(subject.args.to_a).to eql(['--headless'])
end
end
end
Expand Down

0 comments on commit 1674e14

Please sign in to comment.