Skip to content

Commit

Permalink
browserTimeout is in seconds, treat the value as such
Browse files Browse the repository at this point in the history
Fixes #2205
  • Loading branch information
lukeis committed Jun 3, 2016
1 parent 0b1642c commit 1ff4664
Showing 1 changed file with 5 additions and 4 deletions.
9 changes: 5 additions & 4 deletions java/server/src/org/openqa/grid/internal/TestSession.java
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,7 @@
import java.util.HashMap;
import java.util.Map;
import java.util.UUID;
import java.util.concurrent.TimeUnit;
import java.util.logging.Logger;

import javax.servlet.http.HttpServletRequest;
Expand Down Expand Up @@ -193,13 +194,13 @@ public String toString() {

private HttpClient getClient() {
Registry reg = slot.getProxy().getRegistry();
int browserTimeout = reg.getConfiguration().browserTimeout;
if (browserTimeout > 0) {
final int selenium_server_cleanup_cycle = browserTimeout / 10;
long browserTimeout = TimeUnit.SECONDS.toMillis(reg.getConfiguration().browserTimeout);
if (browserTimeout > 0){
final long selenium_server_cleanup_cycle = browserTimeout / 10;
browserTimeout += (selenium_server_cleanup_cycle + MAX_NETWORK_LATENCY);
browserTimeout *=2; // Lets not let this happen too often
}
return slot.getProxy().getHttpClientFactory().getGridHttpClient(browserTimeout, browserTimeout);
return slot.getProxy().getHttpClientFactory().getGridHttpClient((int)browserTimeout, (int)browserTimeout);
}

/*
Expand Down

0 comments on commit 1ff4664

Please sign in to comment.