Skip to content

Commit

Permalink
Don't use js_binary to copy the safari driver client. Buck/crazy-fun's
Browse files Browse the repository at this point in the history
implementation re-adds the closure base library, which we don't need.

(#2277)
  • Loading branch information
jleyba committed Jun 14, 2016
1 parent 51938c4 commit 212a5e7
Show file tree
Hide file tree
Showing 3 changed files with 11 additions and 10 deletions.
2 changes: 1 addition & 1 deletion javascript/node/selenium-webdriver/safari.js
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ const portprober = require('./net/portprober');
/** @const */
const CLIENT_PATH = isDevMode
? path.join(__dirname,
'../../../build/javascript/safari-driver/client.js')
'../../../buck-out/gen/javascript/safari-driver/client.js')
: path.join(__dirname, 'lib/safari/client.js');


Expand Down
10 changes: 5 additions & 5 deletions javascript/safari-driver/BUCK
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
js_binary(name = 'client',
srcs = ['client.js'],
flags = [
'--compilation_level=WHITESPACE_ONLY',
],

export_file(
name = 'client',
src = 'client.js',
out = 'client.js',
visibility = [
'//java/client/src/org/openqa/selenium/safari:client',
],
Expand Down
9 changes: 5 additions & 4 deletions javascript/safari-driver/build.desc
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
# This is a snapshot generated from the same target in the safari branch.
js_binary(
# We don't actually need it renamed, but we do want it copied to build
# output.
rename(
name = "client",
srcs = ["client.js"],
flags = [
"--compilation_level=WHITESPACE_ONLY",
])
out = "client.js
)

0 comments on commit 212a5e7

Please sign in to comment.