Skip to content

Commit

Permalink
Fixing .NET retrieval of "Logs"
Browse files Browse the repository at this point in the history 
Fixes issue #7390
  • Loading branch information
@jimevans
jimevans committed Aug 8, 2019
1 parent 4949f5b commit 26d8b67
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion dotnet/src/webdriver/Remote/RemoteWebDriver.cs
View file
Original file line number Diff line number Diff line change
Expand Up @@ -172,7 +172,7 @@ public RemoteWebDriver(ICommandExecutor commandExecutor, ICapabilities desiredCa
// Only add the legacy log commands if the driver supports
// retrieving the logs via the extension end points.
this.CommandExecutor.CommandInfoRepository.TryAddCommand(DriverCommand.GetAvailableLogTypes, new CommandInfo(CommandInfo.GetCommand, "/session/{sessionId}/se/log/types"));
this.CommandExecutor.CommandInfoRepository.TryAddCommand(DriverCommand.GetLog, new CommandInfo(CommandInfo.GetCommand, "/session/{sessionId}/se/logs"));
this.CommandExecutor.CommandInfoRepository.TryAddCommand(DriverCommand.GetLog, new CommandInfo(CommandInfo.PostCommand, "/session/{sessionId}/se/log"));
}

}
Expand Down

5 comments on commit 26d8b67

@chriscapaci
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this fix in a released version yet?

@jimevans
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not yet. It will go into 4.0 alpha 3, hopefully soon.

@chriscapaci
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, great. That's what I was looking for. I'll wait for the alpha3 and try it out then. Appreciate the fix.

@Jura-Z
Copy link

@Jura-Z Jura-Z commented on 26d8b67 Aug 21, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I applied the change to 4.0 a2 using Cecil and it still doesn't work. @jimevans have you considered enabling tests for the logs - https://github.com/SeleniumHQ/selenium/blob/6a719fff767136a3c83a395d5471c094d0c6cb12/dotnet/test/common/GetLogsTest.cs they all are just disabled...

@jimevans
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They are disabled, as they only apply to a single stable-channel browser. I enabled them locally when I made this change, and they pass.

Please sign in to comment.