Avoid modifying frozen string when receiving unexpected response

SeleniumHQ · Mar 26, 2019 · 2a3fd4c · 2a3fd4c
1 parent d14b44d
commit 2a3fd4c
Showing 1 changed file with 5 additions and 2 deletions.
diff --git a/rb/lib/selenium/webdriver/remote/http/common.rb b/rb/lib/selenium/webdriver/remote/http/common.rb
@@ -89,8 +89,11 @@ def create_response(code, body, content_type)
             elsif code == 204
               Response.new(code)
             else
-              msg = "unexpected response, code=#{code}, content-type=#{content_type.inspect}"
-              msg << "\n#{body}" unless body.empty?
+              msg = if body.empty?
+                      "unexpected response, code=#{code}, content-type=#{content_type.inspect}"
+                    else
+                      "unexpected response, code=#{code}, content-type=#{content_type.inspect}\n#{body}"
+                    end
 
               raise Error::WebDriverError, msg
             end