Correcting .NET Chromium-based Edge service and options classes

SeleniumHQ · Jun 13, 2019 · 30af533 · 30af533
1 parent e80eae1
commit 30af533
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 3 deletions.
diff --git a/dotnet/src/webdriver/Edge/EdgeDriverService.cs b/dotnet/src/webdriver/Edge/EdgeDriverService.cs
@@ -30,7 +30,7 @@ namespace OpenQA.Selenium.Edge
     public sealed class EdgeDriverService : ChromiumDriverService
     {
         private const string MicrosoftWebDriverServiceFileName = "MicrosoftWebDriver.exe";
-        private const string MSEdgeDriverServiceFileName = "MSEdgeDriver.exe";
+        private const string MSEdgeDriverServiceFileName = "msedgedriver";
         private static readonly Uri MicrosoftWebDriverDownloadUrl = new Uri("https://developer.microsoft.com/en-us/microsoft-edge/tools/webdriver/");
         private string host;
         private string package;

diff --git a/dotnet/src/webdriver/Edge/EdgeOptions.cs b/dotnet/src/webdriver/Edge/EdgeOptions.cs
@@ -70,7 +70,7 @@ public EdgeOptions() : this(true)
         /// Create an EdgeOption for ChromiumEdge
         /// </summary>
         /// <param name="isLegacy">Whether to use Legacy Mode. If so, remove all Chromium Capabilities</param>
-        public EdgeOptions(bool isLegacy) : base(BrowserNameValue, "")
+        public EdgeOptions(bool isLegacy) : base(BrowserNameValue)
         {
             this.isLegacy = isLegacy;
 
@@ -88,21 +88,25 @@ public EdgeOptions(bool isLegacy) : base(BrowserNameValue, "")
         }
 
         /// <summary>
-        /// Gets or sets the location of the Chrome browser's binary executable file.
+        /// Gets or sets the location of the Edge browser's binary executable file.
         /// </summary>
         public new string BinaryLocation
         {
             get
             {
                 if (this.isLegacy)
+                {
                     throw new ArgumentException("BinaryLocation does not exist in Legacy Edge");
+                }
 
                 return base.BinaryLocation;
             }
             set
             {
                 if (this.isLegacy)
+                {
                     throw new ArgumentException("BinaryLocation does not exist in Legacy Edge");
+                }
 
                 base.BinaryLocation = value;
             }