[py] chromium service log file name should always use args

Chrome Logging Preferences require logging to be enabled with --log-path

py/selenium/webdriver/chromium/service.py

@@ -16,7 +16,6 @@
 # under the License.
 import typing
 
-from selenium.common import InvalidArgumentException
 from selenium.types import SubprocessStdAlias
 from selenium.webdriver.common import service
 
@@ -42,14 +41,12 @@ def __init__(
         **kwargs,
     ) -> None:
         self.service_args = service_args or []
-        self.log_output = log_output
-        if "--append-log" in self.service_args or "--readable-timestamp" in self.service_args:
-            if isinstance(self.log_output, str):
-                self.service_args.append(f"--log-path={self.log_output}")
-                self.log_output = None
-            else:
-                msg = "Appending logs and readable timestamps require log output to be a string representing file path"
-                raise InvalidArgumentException(msg)
+
+        if isinstance(log_output, str):
+            self.service_args.append(f"--log-path={log_output}")
+            self.log_output = None
+        else:
+            self.log_output = log_output
 
         super().__init__(
             executable=executable_path,

py/test/selenium/webdriver/chrome/chrome_service_tests.py

@@ -18,20 +18,10 @@
 import subprocess
 import time
 
-import pytest
-
 from selenium.webdriver import Chrome
 from selenium.webdriver.chrome.service import Service
 
 
-def test_log_path_deprecated() -> None:
-    log_path = "chromedriver.log"
-    msg = "log_path has been deprecated, please use log_output"
-
-    with pytest.warns(match=msg, expected_warning=DeprecationWarning):
-        Service(log_path=log_path)
-
-
 def test_uses_chromedriver_logging() -> None:
     log_file = "chromedriver.log"
     service_args = ["--append-log"]
@@ -54,6 +44,7 @@ def test_log_output_as_filename() -> None:
     log_file = "chromedriver.log"
     service = Service(log_output=log_file)
     try:
+        assert "--log-path=chromedriver.log" in service.service_args
         driver = Chrome(service=service)
         with open(log_file) as fp:
             assert "Starting ChromeDriver" in fp.readline()

py/test/selenium/webdriver/firefox/firefox_service_tests.py

@@ -23,14 +23,6 @@
 from selenium.webdriver.firefox.service import Service
 
 
-def test_log_path_deprecated() -> None:
-    log_path = "geckodriver.log"
-    msg = "log_path has been deprecated, please use log_output"
-
-    with pytest.warns(match=msg, expected_warning=DeprecationWarning):
-        Service(log_path=log_path)
-
-
 def test_log_output_as_filename() -> None:
     log_file = "geckodriver.log"
     service = Service(log_output=log_file)
@@ -64,17 +56,3 @@ def test_log_output_as_stdout(capfd) -> None:
     out, err = capfd.readouterr()
     assert "geckodriver\tINFO\tListening" in out
     driver.quit()
-
-
-def test_log_output_default_deprecated() -> None:
-    log_name = "geckodriver.log"
-    msg = "Firefox will soon stop logging to geckodriver.log by default; Specify desired logs with log_output"
-
-    try:
-        with pytest.warns(match=msg, expected_warning=DeprecationWarning):
-            driver = Firefox()
-        with open(log_name) as fp:
-            assert "geckodriver\tINFO\tListening" in fp.readline()
-    finally:
-        driver.quit()
-        os.remove(log_name)