Skip to content

Commit

Permalink
Fix the htmlunit-driver tests
Browse files Browse the repository at this point in the history
  • Loading branch information
shs96c committed Feb 22, 2017
1 parent bd5e2e9 commit 3af2b9d
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -321,7 +321,6 @@ public void testShouldReturnValueOfOnClickAttribute() {
}

@Test
@NotYetImplemented(HTMLUNIT)
public void testGetAttributeDoesNotReturnAnObjectForSvgProperties() {
assumeFalse("IE before 9 doesn't support SVG", TestUtilities.isOldIe(driver));

Expand Down
3 changes: 3 additions & 0 deletions java/client/test/org/openqa/selenium/ElementFindingTest.java
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@
import static org.junit.Assert.fail;
import static org.junit.Assume.assumeFalse;
import static org.openqa.selenium.testing.Driver.CHROME;
import static org.openqa.selenium.testing.Driver.HTMLUNIT;
import static org.openqa.selenium.testing.Driver.IE;
import static org.openqa.selenium.testing.Driver.MARIONETTE;
import static org.openqa.selenium.testing.Driver.REMOTE;
Expand All @@ -37,6 +38,7 @@
import org.openqa.selenium.testing.JUnit4TestBase;
import org.openqa.selenium.testing.JavascriptEnabled;
import org.openqa.selenium.testing.NeedsFreshDriver;
import org.openqa.selenium.testing.NotYetImplemented;
import org.openqa.selenium.testing.SwitchToTopAfterTest;
import org.openqa.selenium.testing.TestUtilities;

Expand Down Expand Up @@ -399,6 +401,7 @@ public void testShouldBeAbleToFindElementByXPathWithNamespace() {
}

@Ignore({IE, SAFARI, CHROME})
@NotYetImplemented(value = HTMLUNIT, reason = "This used to work in HtmlUnit 2.23")

This comment has been minimized.

Copy link
@asashour

asashour Feb 23, 2017

Contributor

Noted, thanks

@Test
public void testShouldBeAbleToFindElementByXPathInXmlDocument() {
driver.get(pages.simpleXmlDocument);
Expand Down
1 change: 0 additions & 1 deletion java/client/test/org/openqa/selenium/TextHandlingTest.java
Original file line number Diff line number Diff line change
Expand Up @@ -259,7 +259,6 @@ public void testShouldHandleSiblingBlockLevelElements() {
assertThat(text, is("Some text" + newLine + "Some more text"));
}

@NotYetImplemented(HTMLUNIT)
@Test
public void testShouldHandleNestedBlockLevelElements() {
driver.get(pages.simpleTestPage);
Expand Down

0 comments on commit 3af2b9d

Please sign in to comment.