Skip to content

Commit

Permalink
Reignoring .NET tests for alerts occuring in async JavaScript execution
Browse files Browse the repository at this point in the history
These tests were prematurely unignored for Chrome. The 2.46 version of
chromedriver will allow these tests to pass, and they should be
unignored once that version is released.
  • Loading branch information
jimevans committed Jan 15, 2019
1 parent 6987c60 commit 3d9cad4
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions dotnet/test/common/ExecutingAsyncJavascriptTest.cs
Original file line number Diff line number Diff line change
Expand Up @@ -274,6 +274,7 @@ public void ShouldBeAbleToMakeXMLHttpRequestsAndWaitForTheResponse()
}

[Test]
[IgnoreBrowser(Browser.Chrome, "Does not handle async alerts")]
[IgnoreBrowser(Browser.Safari, "Does not alerts thrown during async JavaScript; driver hangs until alert dismissed")]
[IgnoreBrowser(Browser.Opera, "Does not handle async alerts")]
public void ThrowsIfScriptTriggersAlert()
Expand All @@ -288,6 +289,7 @@ public void ThrowsIfScriptTriggersAlert()
}

[Test]
[IgnoreBrowser(Browser.Chrome, "Does not handle async alerts")]
[IgnoreBrowser(Browser.Safari, "Does not alerts thrown during async JavaScript; driver hangs until alert dismissed")]
[IgnoreBrowser(Browser.Opera, "Does not handle async alerts")]
public void ThrowsIfAlertHappensDuringScript()
Expand All @@ -302,6 +304,7 @@ public void ThrowsIfAlertHappensDuringScript()
}

[Test]
[IgnoreBrowser(Browser.Chrome, "Does not handle async alerts")]
[IgnoreBrowser(Browser.Safari, "Does not alerts thrown during async JavaScript; driver hangs until alert dismissed")]
[IgnoreBrowser(Browser.Opera, "Does not handle async alerts")]
public void ThrowsIfScriptTriggersAlertWhichTimesOut()
Expand All @@ -317,6 +320,7 @@ public void ThrowsIfScriptTriggersAlertWhichTimesOut()
}

[Test]
[IgnoreBrowser(Browser.Chrome, "Does not handle async alerts")]
[IgnoreBrowser(Browser.Safari, "Does not alerts thrown during async JavaScript; driver hangs until alert dismissed")]
[IgnoreBrowser(Browser.Opera, "Does not handle async alerts")]
public void ThrowsIfAlertHappensDuringScriptWhichTimesOut()
Expand Down

0 comments on commit 3d9cad4

Please sign in to comment.