Remove OSS version of Manager and replace it with the W3C version

SeleniumHQ · Apr 18, 2019 · 45ba014 · 45ba014
1 parent 36ff2f0
commit 45ba014
Show file tree

Hide file tree

Showing 4 changed files with 3 additions and 49 deletions.
diff --git a/rb/lib/selenium/webdriver/common.rb b/rb/lib/selenium/webdriver/common.rb
@@ -39,7 +39,6 @@
 require 'selenium/webdriver/common/logger'
 require 'selenium/webdriver/common/logs'
 require 'selenium/webdriver/common/manager'
-require 'selenium/webdriver/common/w3c_manager'
 require 'selenium/webdriver/common/search_context'
 require 'selenium/webdriver/common/interactions/key_actions'
 require 'selenium/webdriver/common/interactions/pointer_actions'

diff --git a/rb/lib/selenium/webdriver/common/manager.rb b/rb/lib/selenium/webdriver/common/manager.rb
@@ -62,7 +62,7 @@ def add_cookie(opts = {})
       #
 
       def cookie_named(name)
-        all_cookies.find { |c| c[:name] == name }
+        convert_cookie(@bridge.cookie(name))
       end
 
       #

diff --git a/rb/lib/selenium/webdriver/common/w3c_manager.rb b/rb/lib/selenium/webdriver/common/w3c_manager.rb
diff --git a/rb/lib/selenium/webdriver/remote/bridge.rb b/rb/lib/selenium/webdriver/remote/bridge.rb
@@ -350,8 +350,8 @@ def execute_async_script(script, *args)
         # cookies
         #
 
-        def options
-          @options ||= WebDriver::W3COptions.new(self)
+        def manage
+          @manage ||= WebDriver::Manager.new(self)
         end
 
         def add_cookie(cookie)