Fixing uninitialized variable in IE

SeleniumHQ · Feb 2, 2019 · 529a57b · 529a57b
1 parent 6e9eb90
commit 529a57b
Show file tree

Hide file tree

Showing 6 changed files with 13 additions and 9 deletions.
diff --git a/cpp/iedriver/IEDriver.rc b/cpp/iedriver/IEDriver.rc
@@ -50,8 +50,8 @@ END
 //
 
 VS_VERSION_INFO VERSIONINFO
- FILEVERSION 3,141,5,6
- PRODUCTVERSION 3,141,5,6
+ FILEVERSION 3,141,5,7
+ PRODUCTVERSION 3,141,5,7
  FILEFLAGSMASK 0x3fL
 #ifdef _DEBUG
  FILEFLAGS 0x1L
@@ -68,12 +68,12 @@ BEGIN
         BEGIN
             VALUE "CompanyName", "Software Freedom Conservancy"
             VALUE "FileDescription", "Driver library for the IE driver"
-            VALUE "FileVersion", "3.141.5.6"
+            VALUE "FileVersion", "3.141.5.7"
             VALUE "InternalName", "IEDriver.dll"
             VALUE "LegalCopyright", "Copyright (C) 2019"
             VALUE "OriginalFilename", "IEDriver.dll"
             VALUE "ProductName", "Selenium WebDriver"
-            VALUE "ProductVersion", "3.141.5.6"
+            VALUE "ProductVersion", "3.141.5.7"
         END
     END
     BLOCK "VarFileInfo"

diff --git a/cpp/iedriver/InputManager.cpp b/cpp/iedriver/InputManager.cpp
@@ -704,7 +704,7 @@ void InputManager::AddKeyboardInput(HWND window_handle,
     // input manager do the rest.
     std::wstring::const_iterator it = key.begin();
     for (; it != key.end(); ++it) {
-      KeyInfo surrogate_key_info;
+      KeyInfo surrogate_key_info = { 0, 0, false, false, false, false, L'\0' };
       surrogate_key_info.scan_code = static_cast<WORD>(*it);
       surrogate_key_info.key_code = 0;
       surrogate_key_info.is_extended_key = false;

diff --git a/cpp/iedriverserver/CHANGELOG b/cpp/iedriverserver/CHANGELOG
@@ -9,6 +9,10 @@ available via the project downloads page. Changes in "revision" field indicate
 private releases checked into the prebuilts directory of the source tree, but
 not made generally available on the downloads page.
 
+v3.141.5.7
+==========
+ * Fixed uninitialized variable in driver.
+
 v3.141.5.6
 ==========
  * Fixed proper keyboard event values for extended keys.

diff --git a/cpp/iedriverserver/IEDriverServer.rc b/cpp/iedriverserver/IEDriverServer.rc
@@ -50,8 +50,8 @@ END
 //
 
 VS_VERSION_INFO VERSIONINFO
- FILEVERSION 3,141,5,6
- PRODUCTVERSION 3,141,5,6
+ FILEVERSION 3,141,5,7
+ PRODUCTVERSION 3,141,5,7
  FILEFLAGSMASK 0x3fL
 #ifdef _DEBUG
  FILEFLAGS 0x1L
@@ -68,12 +68,12 @@ BEGIN
         BEGIN
             VALUE "CompanyName", "Software Freedom Conservancy"
             VALUE "FileDescription", "Command line server for the IE driver"
-            VALUE "FileVersion", "3.141.5.6"
+            VALUE "FileVersion", "3.141.5.7"
             VALUE "InternalName", "IEDriverServer.exe"
             VALUE "LegalCopyright", "Copyright (C) 2019"
             VALUE "OriginalFilename", "IEDriverServer.exe"
             VALUE "ProductName", "Selenium WebDriver"
-            VALUE "ProductVersion", "3.141.5.6"
+            VALUE "ProductVersion", "3.141.5.7"
         END
     END
     BLOCK "VarFileInfo"

diff --git a/cpp/prebuilt/Win32/Release/IEDriverServer.exe b/cpp/prebuilt/Win32/Release/IEDriverServer.exe
diff --git a/cpp/prebuilt/x64/Release/IEDriverServer.exe b/cpp/prebuilt/x64/Release/IEDriverServer.exe