Skip to content

Commit

Permalink
[py] update driver constructor typing
Browse files Browse the repository at this point in the history
  • Loading branch information
titusfortner committed Dec 1, 2023
1 parent e91ba21 commit 5494e07
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 8 deletions.
10 changes: 5 additions & 5 deletions py/selenium/webdriver/chromium/webdriver.py
Expand Up @@ -28,11 +28,11 @@ class ChromiumDriver(RemoteWebDriver):

def __init__(
self,
browser_name,
vendor_prefix,
options: ArgOptions,
service: Service,
keep_alive=True,
browser_name: str = None,
vendor_prefix: str = None,
options: ArgOptions = ArgOptions(),
service: Service = None,
keep_alive: bool = True,
) -> None:
"""Creates a new WebDriver instance of the ChromiumDriver. Starts the
service and then creates new WebDriver instance of ChromiumDriver.
Expand Down
2 changes: 1 addition & 1 deletion py/selenium/webdriver/firefox/webdriver.py
Expand Up @@ -42,7 +42,7 @@ def __init__(
self,
options: Options = None,
service: Service = None,
keep_alive=True,
keep_alive: bool = True,
) -> None:
"""Creates a new instance of the Firefox driver. Starts the service and
then creates new instance of Firefox driver.
Expand Down
4 changes: 2 additions & 2 deletions py/selenium/webdriver/ie/webdriver.py
Expand Up @@ -31,7 +31,7 @@ def __init__(
self,
options: Options = None,
service: Service = None,
keep_alive=True,
keep_alive: bool = True,
) -> None:
"""Creates a new instance of the Ie driver.
Expand All @@ -40,7 +40,7 @@ def __init__(
:Args:
- options - IE Options instance, providing additional IE options
- service - (Optional) service instance for managing the starting and stopping of the driver.
- keep_alive - Deprecated: Whether to configure RemoteConnection to use HTTP keep-alive.
- keep_alive - Whether to configure RemoteConnection to use HTTP keep-alive.
"""

self.service = service if service else Service()
Expand Down

0 comments on commit 5494e07

Please sign in to comment.