[java] Caching non-loopback ipv4 address of the local machine because…

… host resolution is a slow operation
SeleniumHQ · Mar 26, 2019 · 5c2dcce · 5c2dcce
1 parent 5d13914
commit 5c2dcce
Showing 1 changed file with 6 additions and 1 deletion.
diff --git a/java/client/src/org/openqa/selenium/net/NetworkUtils.java b/java/client/src/org/openqa/selenium/net/NetworkUtils.java
@@ -38,6 +38,8 @@
 
 public class NetworkUtils {
 
+  private static String cachedNonLoopbackAddressOfThisMachine;
+
   private final NetworkInterfaceProvider networkInterfaceProvider;
   private volatile String hostname;
   private volatile String address;
@@ -84,7 +86,10 @@ public String getPrivateLocalAddress() {
    * @return A String representing the host name or non-loopback IP4 address of this machine.
    */
   public String getNonLoopbackAddressOfThisMachine() {
-    return getIp4NonLoopbackAddressOfThisMachine().getHostName();
+    if (cachedNonLoopbackAddressOfThisMachine == null) {
+      cachedNonLoopbackAddressOfThisMachine = getIp4NonLoopbackAddressOfThisMachine().getHostName();
+    }
+    return cachedNonLoopbackAddressOfThisMachine;
   }
 
   /**