Modifying ignored tests in .NET test suite

Unignoring now-passing tests for Chrome, updating reasons for ignored tests to be more descriptive, and removing distinction between Firefox with and without Marionette.
SeleniumHQ · Dec 15, 2018 · 6025bed · 6025bed
1 parent 7a18bf5
commit 6025bed
Show file tree

Hide file tree

Showing 14 changed files with 23 additions and 102 deletions.
diff --git a/dotnet/test/common/AlertsTest.cs b/dotnet/test/common/AlertsTest.cs
@@ -153,7 +153,6 @@ public void ShouldAllowAUserToSetTheValueOfAPrompt()
         }
 
         [Test]
-        [IgnoreBrowser(Browser.Chrome, "Chrome does not throw when setting the text of an alert")]
         public void SettingTheValueOfAnAlertThrows()
         {
             driver.Url = CreateAlertPage("cheese");
@@ -525,7 +524,9 @@ public void ShouldHandleAlertOnWindowClose()
         }
 
         [Test]
-        [IgnoreBrowser(Browser.Chrome, "Chrome does not supply text in UnhandledAlertException")]
+        [IgnoreBrowser(Browser.Chrome, "Driver chooses not to return text from unhandled alert")]
+        [IgnoreBrowser(Browser.Edge, "Driver chooses not to return text from unhandled alert")]
+        [IgnoreBrowser(Browser.Firefox, "Driver chooses not to return text from unhandled alert")]
         [IgnoreBrowser(Browser.Opera)]
         [IgnoreBrowser(Browser.Safari, "Safari driver does not do unhandled alerts")]
         public void IncludesAlertTextInUnhandledAlertException()

diff --git a/dotnet/test/common/AvailableLogsTest.cs b/dotnet/test/common/AvailableLogsTest.cs
@@ -7,9 +7,9 @@
 namespace OpenQA.Selenium
 {
     [TestFixture]
+    [IgnoreBrowser(Browser.Edge, "Edge driver does not support logs API")]
     [IgnoreBrowser(Browser.Firefox, "Firefox driver (when using Marionette/Geckodriver) does not support logs API")]
     [IgnoreBrowser(Browser.IE, "IE driver does not support logs API")]
-    [IgnoreBrowser(Browser.Edge, "Edge driver does not support logs API")]
 	[IgnoreBrowser(Browser.Safari, "Edge driver does not support logs API")]
 	public class AvailableLogsTest : DriverTestFixture
     {
@@ -28,11 +28,6 @@ public void QuitDriver()
         [Test]
         public void BrowserLogShouldBeEnabledByDefault()
         {
-            if (TestUtilities.IsMarionette(driver))
-            {
-                Assert.Ignore("Marionette does not support logs API.");
-            }
-
             ReadOnlyCollection<string> logTypes = driver.Manage().Logs.AvailableLogTypes;
             Assert.That(logTypes, Contains.Item(LogType.Browser));
         }
@@ -42,11 +37,6 @@ public void BrowserLogShouldBeEnabledByDefault()
         [NeedsFreshDriver(IsCreatedBeforeTest = true)]
         public void ClientLogShouldBeEnabledByDefault()
         {
-            if (TestUtilities.IsMarionette(driver))
-            {
-                Assert.Ignore("Marionette does not support logs API.");
-            }
-
             // Do one action to have *something* in the client logs.
             driver.Url = formsPage;
             ReadOnlyCollection<string> logTypes = driver.Manage().Logs.AvailableLogTypes;
@@ -66,23 +56,13 @@ public void ClientLogShouldBeEnabledByDefault()
         [Test]
         public void DriverLogShouldBeEnabledByDefault()
         {
-            if (TestUtilities.IsMarionette(driver))
-            {
-                Assert.Ignore("Marionette does not support logs API.");
-            }
-
             ReadOnlyCollection<string> logTypes = driver.Manage().Logs.AvailableLogTypes;
             Assert.That(logTypes, Contains.Item(LogType.Driver), "Remote driver logs should be enabled by default");
         }
 
         [Test]
         public void ProfilerLogShouldBeDisabledByDefault()
         {
-            if (TestUtilities.IsMarionette(driver))
-            {
-                Assert.Ignore("Marionette does not support logs API.");
-            }
-
             ReadOnlyCollection<string> logTypes = driver.Manage().Logs.AvailableLogTypes;
             Assert.That(logTypes, Has.No.Member(LogType.Profiler), "Profiler logs should not be enabled by default");
         }
@@ -91,11 +71,6 @@ public void ProfilerLogShouldBeDisabledByDefault()
         [IgnoreBrowser(Browser.Chrome, "Chrome does not support profiler logs")]
         public void ShouldBeAbleToEnableProfilerLog()
         {
-            if (TestUtilities.IsMarionette(driver))
-            {
-                Assert.Ignore("Marionette does not support logs API.");
-            }
-
             CreateWebDriverWithProfiling();
             ReadOnlyCollection<string> logTypes = localDriver.Manage().Logs.AvailableLogTypes;
             Assert.That(logTypes, Contains.Item(LogType.Profiler), "Profiler log should be enabled");

diff --git a/dotnet/test/common/ChildrenFindingTest.cs b/dotnet/test/common/ChildrenFindingTest.cs
@@ -172,7 +172,6 @@ public void ShouldFindChildElementsById()
         }
 
         [Test]
-        [IgnoreBrowser(Browser.Chrome, "Need to release atoms fix from #4351")]
         public void ShouldNotReturnRootElementWhenFindingChildrenById()
         {
             driver.Url = nestedPage;

diff --git a/dotnet/test/common/ClickTest.cs b/dotnet/test/common/ClickTest.cs
@@ -252,7 +252,6 @@ public void ShouldBeAbleToClickOnAnElementGreaterThanTwoViewports()
         }
 
         [Test]
-        [IgnoreBrowser(Browser.Chrome, "Fails on Chrome")]
         [IgnoreBrowser(Browser.Opera, "Not Tested")]
         public void ShouldBeAbleToClickOnAnElementInFrameGreaterThanTwoViewports()
         {

diff --git a/dotnet/test/common/ContentEditableTest.cs b/dotnet/test/common/ContentEditableTest.cs
@@ -18,7 +18,7 @@ public void SwitchToDefaultContent()
         }
 
         [Test]
-        [IgnoreBrowser(Browser.Firefox)]
+        [IgnoreBrowser(Browser.Firefox, "Browser does not automatically focus body element in frame")]
         public void TypingIntoAnIFrameWithContentEditableOrDesignModeSet()
         {
             driver.Url = richTextPage;
@@ -37,7 +37,7 @@ public void TypingIntoAnIFrameWithContentEditableOrDesignModeSet()
         }
 
         [Test]
-        [IgnoreBrowser(Browser.Firefox)]
+        [IgnoreBrowser(Browser.Firefox, "Browser does not automatically focus body element in frame")]
         [IgnoreBrowser(Browser.Safari, "Non-printable characters do not navigate within element")]
         public void NonPrintableCharactersShouldWorkWithContentEditableOrDesignModeSet()
         {
@@ -63,9 +63,9 @@ public void ShouldBeAbleToTypeIntoEmptyContentEditableElement()
         }
 
         [Test]
-        [IgnoreBrowser(Browser.Chrome)]
+        [IgnoreBrowser(Browser.Chrome, "Driver prepends text in contentEditable areas")]
+        [IgnoreBrowser(Browser.Firefox, "Driver prepends text in contentEditable areas")]
         [IgnoreBrowser(Browser.Safari, "Driver prepends text to contentEditable areas")]
-        [IgnoreBrowser(Browser.Firefox, "Not yet implemented = https://github.com/mozilla/geckodriver/issues/667")]
         public void ShouldBeAbleToTypeIntoContentEditableElementWithExistingValue()
         {
             driver.Url = readOnlyPage;
@@ -92,10 +92,10 @@ public void ShouldBeAbleToTypeIntoTinyMCE()
         }
 
         [Test]
-        [IgnoreBrowser(Browser.Chrome, "Prepends text")]
+        [IgnoreBrowser(Browser.Chrome, "Driver prepends text in contentEditable areas")]
+        [IgnoreBrowser(Browser.Firefox, "Driver prepends text in contentEditable areas")]
         [IgnoreBrowser(Browser.IE, "Prepends text")]
         [IgnoreBrowser(Browser.Safari, "Driver prepends text to contentEditable areas")]
-        [IgnoreBrowser(Browser.Firefox, "Not yet implemented = https://github.com/mozilla/geckodriver/issues/667")]
         public void ShouldAppendToTinyMCE()
         {
             driver.Url = EnvironmentManager.Instance.UrlBuilder.WhereIs("tinymce.html");
@@ -110,8 +110,8 @@ public void ShouldAppendToTinyMCE()
         }
 
         [Test]
-        [IgnoreBrowser(Browser.Chrome, "Prepends text")]
-        [IgnoreBrowser(Browser.Firefox, "Doesn't write anything")]
+        [IgnoreBrowser(Browser.Chrome, "Driver prepends text in contentEditable areas")]
+        [IgnoreBrowser(Browser.Firefox, "Browser does not automatically focus body element in frame")]
         [IgnoreBrowser(Browser.Safari, "Driver prepends text to contentEditable areas")]
         public void AppendsTextToEndOfContentEditableWithMultipleTextNodes()
         {

diff --git a/dotnet/test/common/CookieImplementationTest.cs b/dotnet/test/common/CookieImplementationTest.cs
@@ -712,7 +712,6 @@ public void ShouldAddCookieToCurrentDomainAndPath()
         }
 
         [Test]
-        [IgnoreBrowser(Browser.Firefox)]
         public void ShouldNotShowCookieAddedToDifferentDomain()
         {
             if (!CheckIsOnValidHostNameForCookieTests())

diff --git a/dotnet/test/common/ElementPropertyTest.cs b/dotnet/test/common/ElementPropertyTest.cs
@@ -10,7 +10,7 @@ namespace OpenQA.Selenium
     public class ElementPropertyTest : DriverTestFixture
     {
         [Test]
-        [IgnoreBrowser(Browser.Chrome, "Chrome does not support get element property command")]
+        //[IgnoreBrowser(Browser.Chrome, "Chrome does not support get element property command")]
         [IgnoreBrowser(Browser.Opera)]
         [IgnoreBrowser(Browser.Remote)]
         [IgnoreBrowser(Browser.Safari, "Safari does not support get element property command")]
@@ -23,7 +23,7 @@ public void ShouldReturnNullWhenGettingTheValueOfAPropertyThatIsNotListed()
         }
 
         [Test]
-        [IgnoreBrowser(Browser.Chrome, "Chrome does not support get element property command")]
+        //[IgnoreBrowser(Browser.Chrome, "Chrome does not support get element property command")]
         [IgnoreBrowser(Browser.Opera)]
         [IgnoreBrowser(Browser.Remote)]
         [IgnoreBrowser(Browser.Safari, "Safari does not support get element property command")]

diff --git a/dotnet/test/common/ExecutingAsyncJavascriptTest.cs b/dotnet/test/common/ExecutingAsyncJavascriptTest.cs
@@ -274,7 +274,6 @@ public void ShouldBeAbleToMakeXMLHttpRequestsAndWaitForTheResponse()
         }
 
         [Test]
-        [IgnoreBrowser(Browser.Chrome, "Does not handle async alerts")]
         [IgnoreBrowser(Browser.Safari, "Does not alerts thrown during async JavaScript; driver hangs until alert dismissed")]
         [IgnoreBrowser(Browser.Opera, "Does not handle async alerts")]
 		public void ThrowsIfScriptTriggersAlert()
@@ -289,7 +288,6 @@ public void ThrowsIfScriptTriggersAlert()
         }
 
         [Test]
-        [IgnoreBrowser(Browser.Chrome, "Does not handle async alerts")]
         [IgnoreBrowser(Browser.Safari, "Does not alerts thrown during async JavaScript; driver hangs until alert dismissed")]
         [IgnoreBrowser(Browser.Opera, "Does not handle async alerts")]
         public void ThrowsIfAlertHappensDuringScript()
@@ -304,7 +302,6 @@ public void ThrowsIfAlertHappensDuringScript()
         }
 
         [Test]
-        [IgnoreBrowser(Browser.Chrome, "Does not handle async alerts")]
         [IgnoreBrowser(Browser.Safari, "Does not alerts thrown during async JavaScript; driver hangs until alert dismissed")]
         [IgnoreBrowser(Browser.Opera, "Does not handle async alerts")]
         public void ThrowsIfScriptTriggersAlertWhichTimesOut()
@@ -320,7 +317,6 @@ public void ThrowsIfScriptTriggersAlertWhichTimesOut()
         }
 
         [Test]
-        [IgnoreBrowser(Browser.Chrome, "Does not handle async alerts")]
         [IgnoreBrowser(Browser.Safari, "Does not alerts thrown during async JavaScript; driver hangs until alert dismissed")]
         [IgnoreBrowser(Browser.Opera, "Does not handle async alerts")]
         public void ThrowsIfAlertHappensDuringScriptWhichTimesOut()
@@ -335,7 +331,7 @@ public void ThrowsIfAlertHappensDuringScriptWhichTimesOut()
         }
 
         [Test]
-        [IgnoreBrowser(Browser.Chrome, "Does not handle async alerts")]
+        [IgnoreBrowser(Browser.Chrome, "Driver chooses not to return text from unhandled alert")]
         [IgnoreBrowser(Browser.Edge, "Driver chooses not to return text from unhandled alert")]
         [IgnoreBrowser(Browser.Firefox, "Driver chooses not to return text from unhandled alert")]
         [IgnoreBrowser(Browser.Safari, "Does not alerts thrown during async JavaScript; driver hangs until alert dismissed")]

diff --git a/dotnet/test/common/GetLogsTest.cs b/dotnet/test/common/GetLogsTest.cs
@@ -9,8 +9,9 @@
 namespace OpenQA.Selenium
 {
     [TestFixture]
-    [IgnoreBrowser(Browser.IE, "IE driver does not support logs API")]
     [IgnoreBrowser(Browser.Edge, "Edge driver does not support logs API")]
+    [IgnoreBrowser(Browser.Firefox, "Firefox driver (when using Marionette/Geckodriver) does not support logs API")]
+    [IgnoreBrowser(Browser.IE, "IE driver does not support logs API")]
 	[IgnoreBrowser(Browser.Safari, "Edge driver does not support logs API")]
     public class GetLogsTest : DriverTestFixture
     {
@@ -29,11 +30,6 @@ public void QuitDriver()
         [Test]
         public void LogBufferShouldBeResetAfterEachGetLogCall()
         {
-            if (TestUtilities.IsMarionette(driver))
-            {
-                Assert.Ignore("Marionette does not support logs API.");
-            }
-
             ReadOnlyCollection<string> logTypes = driver.Manage().Logs.AvailableLogTypes;
             foreach (string logType in logTypes)
             {
@@ -50,11 +46,6 @@ public void LogBufferShouldBeResetAfterEachGetLogCall()
         [Test]
         public void DifferentLogsShouldNotContainTheSameLogEntries()
         {
-            if (TestUtilities.IsMarionette(driver))
-            {
-                Assert.Ignore("Marionette does not support logs API.");
-            }
-
             driver.Url = simpleTestPage;
             Dictionary<string, ReadOnlyCollection<LogEntry>> logTypeToEntriesDictionary = new Dictionary<string, ReadOnlyCollection<LogEntry>>();
             ReadOnlyCollection<string> logTypes = driver.Manage().Logs.AvailableLogTypes;
@@ -78,11 +69,6 @@ public void DifferentLogsShouldNotContainTheSameLogEntries()
         [Test]
         public void TurningOffLogShouldMeanNoLogMessages()
         {
-            if (TestUtilities.IsMarionette(driver))
-            {
-                Assert.Ignore("Marionette does not support logs API.");
-            }
-
             ReadOnlyCollection<string> logTypes = driver.Manage().Logs.AvailableLogTypes;
             foreach (string logType in logTypes)
             {

diff --git a/dotnet/test/common/PageLoadingTest.cs b/dotnet/test/common/PageLoadingTest.cs
@@ -148,14 +148,9 @@ public void ShouldFollowMetaRedirects()
         }
 
         [Test]
+        [IgnoreBrowser(Browser.Firefox, "Browser doesn't see subsequent navigation to a fragment as a new navigation.")]
         public void ShouldBeAbleToGetAFragmentOnTheCurrentPage()
         {
-            if (TestUtilities.IsMarionette(driver))
-            {
-                // Don't run this test on Marionette.
-                Assert.Ignore("Marionette doesn't see subsequent navigation to a fragment as a new navigation.");
-            }
-
             driver.Url = xhtmlTestPage;
             driver.Url = xhtmlTestPage + "#text";
             driver.FindElement(By.Id("id1"));

diff --git a/dotnet/test/common/PositionAndSizeTest.cs b/dotnet/test/common/PositionAndSizeTest.cs
@@ -131,7 +131,6 @@ public void ShouldCorrectlyIdentifyThatAnElementHasWidthAndHeight()
 
         [Test]
         [IgnoreBrowser(Browser.Opera)]
-        [IgnoreBrowser(Browser.Chrome, "WebKit bug 28804")]
         public void ShouldHandleNonIntegerPositionAndSize()
         {
             driver.Url = rectanglesPage;

diff --git a/dotnet/test/common/TypingTest.cs b/dotnet/test/common/TypingTest.cs
@@ -657,14 +657,10 @@ public void CanClearNumberInputAfterTypingInvalidInput()
         // Tests below here are not included in the Java test suite
         //------------------------------------------------------------------
         [Test]
+        [IgnoreBrowser(Browser.Firefox, "Browser does not automatically focus body element in frame")]
         [IgnoreBrowser(Browser.Opera, "Does not support contentEditable")]
         public void TypingIntoAnIFrameWithContentEditableOrDesignModeSet()
         {
-            if (TestUtilities.IsMarionette(driver))
-            {
-                Assert.Ignore("Marionette does not ContentEditable.");
-            }
-
             driver.Url = richTextPage;
 
             driver.SwitchTo().Frame("editFrame");
@@ -680,15 +676,11 @@ public void TypingIntoAnIFrameWithContentEditableOrDesignModeSet()
         }
 
         [Test]
+        //[IgnoreBrowser(Browser.Chrome, "Driver prepends text in contentEditable")]
+        [IgnoreBrowser(Browser.Firefox, "Browser does not automatically focus body element in frame")]
         [IgnoreBrowser(Browser.Opera, "Does not support contentEditable")]
-        [IgnoreBrowser(Browser.Chrome, "ChromeDriver prepends text in contentEditable")]
         public void NonPrintableCharactersShouldWorkWithContentEditableOrDesignModeSet()
         {
-            if (TestUtilities.IsMarionette(driver))
-            {
-                Assert.Ignore("Marionette does not ContentEditable.");
-            }
-
             driver.Url = richTextPage;
 
             // not tested on mac
@@ -712,11 +704,6 @@ public void NonPrintableCharactersShouldWorkWithContentEditableOrDesignModeSet()
         [IgnoreBrowser(Browser.Opera, "Does not support contentEditable")]
         public void ShouldBeAbleToTypeIntoEmptyContentEditableElement()
         {
-            if (TestUtilities.IsMarionette(driver))
-            {
-                Assert.Ignore("Marionette does not ContentEditable.");
-            }
-
             driver.Url = readOnlyPage;
             IWebElement editable = driver.FindElement(By.Id("content-editable"));
 
@@ -727,14 +714,10 @@ public void ShouldBeAbleToTypeIntoEmptyContentEditableElement()
         }
 
         [Test]
-        [IgnoreBrowser(Browser.Chrome, "ChromeDriver prepends text")]
+        [IgnoreBrowser(Browser.Chrome, "Driver prepends text in contentEditable")]
+        [IgnoreBrowser(Browser.Firefox, "Driver prepends text in contentEditable")]
         public void ShouldBeAbleToTypeIntoContentEditableElementWithExistingValue()
         {
-            if (TestUtilities.IsMarionette(driver))
-            {
-                Assert.Ignore("Marionette does not ContentEditable.");
-            }
-
             driver.Url = readOnlyPage;
             IWebElement editable = driver.FindElement(By.Id("content-editable"));