Add a test for [Keys.ARROW_LEFT].

keys_to_typing handles list of Keys.

keys_to_typing behavior was regressed by an
implementation change. This change reverts
keys_to_typing to its former behavior.

That is, element.send_keys([Keys.ENTER])
should result in the ENTER key being
pressed, not the unicode representation of
ENTER defined in common/keys.py to be
typed into a text field.

Fixes #1839

Signed-off-by: Luke Inman-Semerau <luke.semerau@gmail.com>

py/selenium/webdriver/common/utils.py

@@ -18,7 +18,9 @@
 """
 The Utils methods.
 """
+
 import socket
+from selenium.webdriver.common.keys import Keys
 
 try:
     basestring
@@ -83,13 +85,13 @@ def keys_to_typing(value):
     """Processes the values that will be typed in the element."""
     typing = []
     for val in value:
-        # If it is a non-string object, make it a string
-        if not isinstance(val, basestring):
-            # This str() call enables for abstraction if one has a custom object that has some
-            # UI representation to implement __str__() to return the representation, making it
-            # possible to pass that object to the filling methods.
+        if isinstance(val, Keys):
+            typing.append(val)
+        elif isinstance(val, int):
             val = str(val)
-        # Then just add the separate characters in the list
-        # ['e'].extend('asdf')  =>  ['e', 'a', 's', 'd', 'f']
-        typing.extend(val)
+            for i in range(len(val)):
+                typing.append(val[i])
+        else:
+            for i in range(len(val)):
+                typing.append(val[i])
     return typing

py/test/selenium/webdriver/common/typing_tests.py

@@ -78,6 +78,12 @@ def testArrowKeysShouldNotBePrintable(self):
         keyReporter.send_keys(Keys.ARROW_LEFT)
         self.assertEqual(keyReporter.get_attribute("value"), "")
 
+    def testListOfArrowKeysShouldNotBePrintable(self):
+        self._loadPage("javascriptPage")
+        keyReporter = self.driver.find_element(by=By.ID, value="keyReporter")
+        keyReporter.send_keys([Keys.ARROW_LEFT])
+        self.assertEqual(keyReporter.get_attribute("value"), "")
+
     def testShouldBeAbleToUseArrowKeys(self):
         self._loadPage("javascriptPage")
         keyReporter = self.driver.find_element(by=By.ID, value="keyReporter")