Updating .NET test framework to allow hiding test web server command …

…window
SeleniumHQ · Jul 10, 2019 · 6275e4e · 6275e4e
1 parent b52106b
commit 6275e4e
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 3 deletions.
diff --git a/dotnet/test/common/Environment/EnvironmentManager.cs b/dotnet/test/common/Environment/EnvironmentManager.cs
@@ -29,6 +29,7 @@ private EnvironmentManager()
             TestEnvironment env = JsonConvert.DeserializeObject<TestEnvironment>(content);
 
             bool captureWebServerOutput = TestContext.Parameters.Get<bool>("CaptureWebServerOutput", false);
+            bool hideWebServerCommandPrompt = TestContext.Parameters.Get<bool>("HideWebServerCommandPrompt", true);
             string activeDriverConfig = TestContext.Parameters.Get("ActiveDriverConfig", env.ActiveDriverConfig);
             string activeWebsiteConfig = TestContext.Parameters.Get("ActiveWebsiteConfig", env.ActiveWebsiteConfig);
             string driverServiceLocation = TestContext.Parameters.Get("DriverServiceLocation", env.DriverServiceLocation);
@@ -107,7 +108,7 @@ private EnvironmentManager()
                 projectRoot += "/selenium";
             }
 
-            webServer = new TestWebServer(projectRoot, captureWebServerOutput);
+            webServer = new TestWebServer(projectRoot, captureWebServerOutput, hideWebServerCommandPrompt);
             bool autoStartRemoteServer = false;
             if (browser == Browser.Remote)
             {

diff --git a/dotnet/test/common/Environment/TestWebServer.cs b/dotnet/test/common/Environment/TestWebServer.cs
@@ -15,13 +15,15 @@ public class TestWebServer
         private string standaloneTestJar = @"java/client/test/org/openqa/selenium/environment/appserver_deploy.jar";
         private string projectRootPath;
         private bool captureWebServerOutput;
+        private bool hideCommandPrompt;
 
         private StringBuilder outputData = new StringBuilder();
 
-        public TestWebServer(string projectRoot, bool captureWebServerOutput)
+        public TestWebServer(string projectRoot, bool captureWebServerOutput, bool hideCommandPrompt)
         {
             projectRootPath = projectRoot;
             this.captureWebServerOutput = captureWebServerOutput;
+            this.hideCommandPrompt = hideCommandPrompt;
         }
 
         public void Start()
@@ -70,11 +72,12 @@ public void Start()
                 webserverProcess.StartInfo.FileName = javaExecutableName;
                 webserverProcess.StartInfo.Arguments = processArgsBuilder.ToString();
                 webserverProcess.StartInfo.WorkingDirectory = projectRootPath;
+                webserverProcess.StartInfo.UseShellExecute = !(hideCommandPrompt || captureWebServerOutput);
+                webserverProcess.StartInfo.CreateNoWindow = hideCommandPrompt;
                 if (captureWebServerOutput)
                 {
                     webserverProcess.StartInfo.RedirectStandardOutput = true;
                     webserverProcess.StartInfo.RedirectStandardError = true;
-                    webserverProcess.StartInfo.UseShellExecute = false;
                 }
 
                 webserverProcess.Start();