[rb] fix bug in default durations

SeleniumHQ · May 31, 2022 · 6652c1a · 6652c1a
1 parent f677d2d
commit 6652c1a
Show file tree

Hide file tree

Showing 5 changed files with 9 additions and 4 deletions.
diff --git a/rb/lib/selenium/webdriver/common/interactions/pointer_actions.rb b/rb/lib/selenium/webdriver/common/interactions/pointer_actions.rb
@@ -28,7 +28,7 @@ module PointerActions
       #
 
       def default_move_duration
-        @default_move_duration ||= @duration / 1000 # convert ms to seconds
+        @default_move_duration ||= @duration / 1000.0 # convert ms to seconds
       end
 
       #

diff --git a/rb/lib/selenium/webdriver/common/interactions/wheel_actions.rb b/rb/lib/selenium/webdriver/common/interactions/wheel_actions.rb
@@ -28,7 +28,7 @@ module WheelActions
       #
 
       def default_scroll_duration
-        @default_scroll_duration ||= @duration / 1000 # convert ms to seconds
+        @default_scroll_duration ||= @duration / 1000.0 # convert ms to seconds
       end
 
       #

diff --git a/rb/spec/integration/selenium/webdriver/action_builder_spec.rb b/rb/spec/integration/selenium/webdriver/action_builder_spec.rb
@@ -262,7 +262,7 @@ module WebDriver
 
       describe 'pen stylus', except: {browser: :firefox, reason: 'Unknown pointerType'} do
         it 'sets pointer event properties' do
-          driver.get 'https://titusfortner.com/examples/pointerActionsPage.html'
+          driver.navigate.to url_for('pointerActionsPage.html')
           pointer_area = driver.find_element(id: 'pointerArea')
           rect = pointer_area.rect
           x_val = rect.x

diff --git a/rb/spec/integration/selenium/webdriver/spec_support/test_environment.rb b/rb/spec/integration/selenium/webdriver/spec_support/test_environment.rb
@@ -29,7 +29,7 @@ def initialize
 
           extract_browser_from_bazel_target_name
 
-          @driver = ENV.fetch('WD_SPEC_DRIVER', :firefox).to_sym
+          @driver = ENV.fetch('WD_SPEC_DRIVER', :chrome).to_sym
           @driver_instance = nil
         end
 

diff --git a/rb/spec/unit/selenium/webdriver/common/action_builder_spec.rb b/rb/spec/unit/selenium/webdriver/common/action_builder_spec.rb
@@ -60,6 +60,11 @@ module WebDriver
           expect(action_builder.devices).to eq([mouse, keyboard, none, touch])
         end
 
+        it 'accepts duration' do
+          action_builder = ActionBuilder.new(bridge, duration: 2200)
+          expect(action_builder.default_move_duration).to eq(2.2)
+        end
+
         it 'does not accept additional devices if deprecated parameters are used' do
           none = Interactions.none('none')
           touch = Interactions.pointer(:touch, name: 'touch')