Skip to content

Commit

Permalink
Add Firefox options to capabilities
Browse files Browse the repository at this point in the history
When the firefox_options argument is not provided we generate a FirefoxOptions object, but due to some broken logic we weren't updating the capabilities from these options.
  • Loading branch information
davehunt authored and AutomatedTester committed May 18, 2016
1 parent 3527d67 commit 677618b
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions py/selenium/webdriver/firefox/webdriver.py
Original file line number Diff line number Diff line change
Expand Up @@ -66,11 +66,11 @@ def __init__(self, firefox_profile=None, firefox_binary=None, timeout=30,
firefox_options = Options()
firefox_options.binary_location = self.binary if isinstance(self.binary, basestring) else self.binary._get_firefox_start_cmd()
firefox_options.profile = self.profile

if capabilities is None:
capabilities = firefox_options.to_capabilities()
else:
if capabilities is None:
capabilities = firefox_options.to_capabilities()
else:
capabilities.update(firefox_options.to_capabilities())
capabilities.update(firefox_options.to_capabilities())

# marionette
if capabilities.get("marionette"):
Expand Down

0 comments on commit 677618b

Please sign in to comment.