Skip to content

Commit

Permalink
[nodejs] Node.js test server always uses loopback address so we shoul…
Browse files Browse the repository at this point in the history
…d explicitly exclude it from bypass list, but let's do it in a modern fashion
  • Loading branch information
barancev committed Feb 1, 2019
1 parent 643b9cc commit 685a737
Showing 1 changed file with 2 additions and 7 deletions.
9 changes: 2 additions & 7 deletions javascript/node/selenium-webdriver/test/proxy_test.js
Original file line number Diff line number Diff line change
Expand Up @@ -100,12 +100,6 @@ test.suite(function(env) {

function createDriver(proxy) {
return driver = env.builder()
// For Firefox we need to explicitly enable proxies for localhost by
// clearing the network.proxy.no_proxies_on preference.
.setFirefoxOptions(
new firefox.Options()
.setBinary(firefox.Channel.AURORA)
.setPreference('network.proxy.no_proxies_on', ''))
.setProxy(proxy)
.build();
}
Expand All @@ -115,7 +109,8 @@ test.suite(function(env) {
describe('manual proxy settings', function() {
it('can configure HTTP proxy host', async function() {
await createDriver(proxy.manual({
http: proxyServer.host()
http: proxyServer.host(),
bypass: []
}));

await driver.get(helloServer.url());
Expand Down

0 comments on commit 685a737

Please sign in to comment.