turn on http keep alive while using ChromeDriver (#5759)

* turn on http keep alive while using ChromeDriver need chrome driver 2.35 or above fix #5758 * add ECONNREFUSED as retryable network error after enable HTTP keep alive, chromedriver sometimes refused connection
SeleniumHQ · Dec 15, 2018 · 6adc9dc · 6adc9dc
1 parent 105994c
commit 6adc9dc
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/javascript/node/selenium-webdriver/chrome.js b/javascript/node/selenium-webdriver/chrome.js
@@ -171,7 +171,8 @@ const Command = {
  * @return {!command.Executor} The new command executor.
  */
 function createExecutor(url) {
-  let client = url.then(url => new http.HttpClient(url));
+  let agent = new http.Agent({ keepAlive: true });
+  let client = url.then(url => new http.HttpClient(url, agent));
   let executor = new http.Executor(client);
   configureExecutor(executor);
   return executor;

diff --git a/javascript/node/selenium-webdriver/http/index.js b/javascript/node/selenium-webdriver/http/index.js
@@ -287,6 +287,7 @@ function isRetryableNetworkError(err) {
   if (err && err.code) {
     return err.code === 'ECONNABORTED' ||
           err.code === 'ECONNRESET' ||
+          err.code === 'ECONNREFUSED' ||
           err.code === 'EADDRINUSE' ||
           err.code === 'EPIPE';
   }
@@ -297,6 +298,7 @@ function isRetryableNetworkError(err) {
 
 // PUBLIC API
 
+exports.Agent = http.Agent;
 exports.Executor = httpLib.Executor;
 exports.HttpClient = HttpClient;
 exports.Request = httpLib.Request;