Fix ArgumentError when starting persistent HTTP client

We don't really need to start its connection. Closes #7158
SeleniumHQ · May 3, 2019 · 6b069e2 · 6b069e2 · dluong777 · Jun 26, 2019
1 parent a25638d
commit 6b069e2
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 1 deletion.
diff --git a/rb/lib/selenium/webdriver/remote/http/default.rb b/rb/lib/selenium/webdriver/remote/http/default.rb
@@ -59,10 +59,15 @@ def http
               http.open_timeout = open_timeout
               http.read_timeout = read_timeout if read_timeout
 
-              http.start
+              start(http)
+              http
             end
           end
 
+          def start(http)
+            http.start
+          end
+
           MAX_RETRIES = 3
 
           def request(verb, url, headers, payload, redirects = 0)

diff --git a/rb/lib/selenium/webdriver/remote/http/persistent.rb b/rb/lib/selenium/webdriver/remote/http/persistent.rb
@@ -31,6 +31,10 @@ def close
 
           private
 
+          def start(*)
+            # no need to explicitly start connection
+          end
+
           def new_http_client
             proxy = nil