[java] Fixing file stream leaking in legacy Firefox driver

SeleniumHQ · Apr 13, 2019 · 7543249 · 7543249
1 parent f78cbf9
commit 7543249
Showing 1 changed file with 3 additions and 11 deletions.
diff --git a/java/client/src/org/openqa/selenium/firefox/xpi/XpiDriverService.java b/java/client/src/org/openqa/selenium/firefox/xpi/XpiDriverService.java
@@ -100,7 +100,6 @@ private XpiDriverService(
       } else if ("/dev/null".equals(firefoxLogFile)) {
         sendOutputTo(ByteStreams.nullOutputStream());
       } else {
-        // TODO: This stream is leaked.
         sendOutputTo(new FileOutputStream(firefoxLogFile));
       }
     } else {
@@ -239,16 +238,9 @@ protected void waitUntilAvailable() throws MalformedURLException {
 
   @Override
   public void stop() {
-    lock.lock();
-    try {
-      if (process != null) {
-        process.destroy();
-      }
-      profile.cleanTemporaryModel();
-      profile.clean(profileDir);
-    } finally {
-      lock.unlock();
-    }
+    super.stop();
+    profile.cleanTemporaryModel();
+    profile.clean(profileDir);
   }
 
   private void addWebDriverExtension(FirefoxProfile profile) {