rb - chrome profile zip no longer applicable for current options

SeleniumHQ · Sep 18, 2016 · 7cefa09 · 7cefa09
1 parent 88fdb88
commit 7cefa09
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 11 deletions.
diff --git a/rb/lib/selenium/webdriver/chrome/profile.rb b/rb/lib/selenium/webdriver/chrome/profile.rb
@@ -81,7 +81,6 @@ def as_json(*)
 
           opts = {directory: @directory || layout_on_disk}
           opts[:extensions] = extensions if extensions
-          opts[:zip] = Zipper.zip(@directory)
           opts
         end
 

diff --git a/rb/spec/integration/selenium/webdriver/chrome/profile_spec.rb b/rb/spec/integration/selenium/webdriver/chrome/profile_spec.rb
@@ -43,13 +43,6 @@ module Chrome
             driver.quit
           end
 
-          it 'should be serializable to JSON' do
-            profile['foo.boolean'] = true
-
-            new_profile = Profile.from_json(profile.to_json)
-            expect(new_profile['foo.boolean']).to be true
-          end
-
           it 'adds an extension' do
             ext_path = '/some/path.crx'
 
@@ -68,10 +61,8 @@ module Chrome
             expect(ext_file).to receive(:read).and_return 'test'
 
             expect(profile).to receive(:layout_on_disk).and_return 'ignored'
-            expect(Zipper).to receive(:zip).and_return 'ignored'
 
-            expect(profile.as_json).to eq(zip: 'ignored',
-                                          directory: 'ignored',
+            expect(profile.as_json).to eq(directory: 'ignored',
                                           extensions: [Base64.strict_encode64('test')])
           end