Skip to content

Commit

Permalink
[rb] Fix Chromium tests on Windows
Browse files Browse the repository at this point in the history
Apparently no-sandbox would keep zombie Chromium processes and would starve the resources. See #5600.
  • Loading branch information
p0deje committed May 2, 2024
1 parent ef96a7b commit 8688ad2
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 7 deletions.
5 changes: 0 additions & 5 deletions .github/workflows/ci-ruby.yml
Original file line number Diff line number Diff line change
Expand Up @@ -87,11 +87,6 @@ jobs:
os: ubuntu
- browser: safari
os: windows
# TODO: Investigate why they are timing out
- browser: chrome
os: windows
- browser: edge
os: windows
with:
name: Local Tests (${{ matrix.browser }}, ${{ matrix.os }})
browser: ${{ matrix.browser }}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -243,15 +243,13 @@ def safari_preview_driver(**opts)
def chrome_options(args: [], **opts)
opts[:binary] ||= ENV['CHROME_BINARY'] if ENV.key?('CHROME_BINARY')
args << '--headless=chrome' if ENV['HEADLESS']
args << '--no-sandbox'
args << '--disable-gpu'
WebDriver::Options.chrome(browser_version: 'stable', args: args, **opts)
end

def edge_options(args: [], **opts)
opts[:binary] ||= ENV['EDGE_BINARY'] if ENV.key?('EDGE_BINARY')
args << '--headless=chrome' if ENV['HEADLESS']
args << '--no-sandbox'
args << '--disable-gpu'
WebDriver::Options.edge(browser_version: 'stable', args: args, **opts)
end
Expand Down

0 comments on commit 8688ad2

Please sign in to comment.