Move the okhttpclient to the okhttp package

SeleniumHQ · Jul 4, 2019 · 8e5176c · 8e5176c
1 parent 46d3642
commit 8e5176c
Show file tree

Hide file tree

Showing 11 changed files with 41 additions and 14 deletions.
diff --git a/java/client/src/org/openqa/selenium/remote/BUCK b/java/client/src/org/openqa/selenium/remote/BUCK
@@ -108,8 +108,6 @@ java_library(
         "html5/RemoteLocationContext.java",
         "html5/RemoteSessionStorage.java",
         "html5/RemoteWebStorage.java",
-        "internal/OkHttpClient.java",
-        "internal/OkHttpWebSocket.java",
         "internal/JsonToWebElementConverter.java",
         "internal/WebElementToJsonConverter.java",
         "mobile/RemoteNetworkConnection.java",
@@ -135,6 +133,7 @@ java_library(
     ],
     deps = [
         "//java/client/src/org/openqa/selenium:selenium",
+        "//java/client/src/org/openqa/selenium/remote/http/okhttp:okhttp",
         "//third_party/java/guava:guava",
     ],
 )

diff --git a/java/client/src/org/openqa/selenium/remote/BUILD.bazel b/java/client/src/org/openqa/selenium/remote/BUILD.bazel
@@ -71,6 +71,7 @@ java_library(
         ":capabilities",
         ":remote-lib",
         "//java/client/src/org/openqa/selenium:core",
+        "//java/client/src/org/openqa/selenium/remote/http/okhttp",
         "//third_party/java/bytebuddy:byte-buddy",
         "//third_party/java/guava",
     ],
@@ -139,7 +140,6 @@ java_library(
         "//java/client/src/org/openqa/selenium/remote/http",
         "//java/client/src/org/openqa/selenium/remote/session",
         "//third_party/java/guava",
-        "//third_party/java/okhttp3:okhttp",
     ],
 )
 

diff --git a/java/client/src/org/openqa/selenium/remote/http/HttpClient.java b/java/client/src/org/openqa/selenium/remote/http/HttpClient.java
@@ -42,7 +42,7 @@ static Factory createDefault() {
         default:
           try {
             Class<? extends Factory> clazz =
-                Class.forName("org.openqa.selenium.remote.internal.OkHttpClient$Factory")
+                Class.forName("org.openqa.selenium.remote.http.okhttp.OkHttpClient$Factory")
                     .asSubclass(Factory.class);
             return clazz.newInstance();
           } catch (ReflectiveOperationException e) {

diff --git a/java/client/src/org/openqa/selenium/remote/http/okhttp/BUCK b/java/client/src/org/openqa/selenium/remote/http/okhttp/BUCK
@@ -0,0 +1,13 @@
+java_library(
+    name = "okhttp",
+    srcs = glob(["*.java"]),
+    deps = [
+        "//java/client/src/org/openqa/selenium/remote/http:http",
+        "//third_party/java/guava:guava",
+        "//third_party/java/okhttp3:okhttp",
+    ],
+    visibility = [
+        "//java/client/src/org/openqa/selenium/remote:",
+        "//java/client/test/org/openqa/selenium/remote/http/okhttp:",
+    ],
+)
diff --git a/java/client/src/org/openqa/selenium/remote/http/okhttp/BUILD.bazel b/java/client/src/org/openqa/selenium/remote/http/okhttp/BUILD.bazel
@@ -7,6 +7,7 @@ java_library(
         "//third_party/java/okhttp3:okhttp",
     ],
     visibility = [
+        "//java/client/src/org/openqa/selenium/remote:__pkg__",
         "//java/client/test/org/openqa/selenium/remote/http/okhttp:__pkg__",
     ],
 )
diff --git a/...elenium/remote/internal/OkHttpClient.java → ...nium/remote/http/okhttp/OkHttpClient.java b/...elenium/remote/internal/OkHttpClient.java → ...nium/remote/http/okhttp/OkHttpClient.java
@@ -15,12 +15,21 @@
 // specific language governing permissions and limitations
 // under the License.
 
-package org.openqa.selenium.remote.internal;
+package org.openqa.selenium.remote.http.okhttp;
 
 import com.google.common.base.Strings;
-import okhttp3.*;
+import okhttp3.ConnectionPool;
+import okhttp3.Credentials;
+import okhttp3.HttpUrl;
+import okhttp3.MediaType;
+import okhttp3.Request;
+import okhttp3.RequestBody;
+import okhttp3.Response;
+import org.openqa.selenium.remote.http.ClientConfig;
+import org.openqa.selenium.remote.http.HttpClient;
+import org.openqa.selenium.remote.http.HttpRequest;
+import org.openqa.selenium.remote.http.HttpResponse;
 import org.openqa.selenium.remote.http.WebSocket;
-import org.openqa.selenium.remote.http.*;
 
 import java.io.IOException;
 import java.io.UncheckedIOException;
@@ -30,7 +39,9 @@
 
 import static java.util.concurrent.TimeUnit.MILLISECONDS;
 import static org.openqa.selenium.remote.http.AddSeleniumUserAgent.USER_AGENT;
-import static org.openqa.selenium.remote.http.Contents.*;
+import static org.openqa.selenium.remote.http.Contents.bytes;
+import static org.openqa.selenium.remote.http.Contents.empty;
+import static org.openqa.selenium.remote.http.Contents.memoize;
 
 public class OkHttpClient implements HttpClient {
 

diff --git a/...nium/remote/internal/OkHttpWebSocket.java → ...m/remote/http/okhttp/OkHttpWebSocket.java b/...nium/remote/internal/OkHttpWebSocket.java → ...m/remote/http/okhttp/OkHttpWebSocket.java
@@ -15,7 +15,7 @@
 // specific language governing permissions and limitations
 // under the License.
 
-package org.openqa.selenium.remote.internal;
+package org.openqa.selenium.remote.http.okhttp;
 
 import org.openqa.selenium.remote.http.WebSocket;
 

diff --git a/java/client/test/org/openqa/selenium/remote/BUCK b/java/client/test/org/openqa/selenium/remote/BUCK
@@ -13,7 +13,6 @@ java_test(
         "W3CHandshakeResponseTest.java",
         "W3CRemoteDriverTest.java",
         "internal/HttpClientTestBase.java",
-        "internal/OkHttpClientTest.java",
         "internal/WebElementToJsonConverterTest.java",
     ],
     labels = [

diff --git a/...ium/remote/internal/OkHttpClientTest.java → .../remote/http/okhttp/OkHttpClientTest.java b/...ium/remote/internal/OkHttpClientTest.java → .../remote/http/okhttp/OkHttpClientTest.java
@@ -15,9 +15,10 @@
 // specific language governing permissions and limitations
 // under the License.
 
-package org.openqa.selenium.remote.internal;
+package org.openqa.selenium.remote.http.okhttp;
 
 import org.openqa.selenium.remote.http.HttpClient;
+import org.openqa.selenium.remote.internal.HttpClientTestBase;
 
 public class OkHttpClientTest extends HttpClientTestBase {
 

diff --git a/java/server/src/org/openqa/grid/internal/BaseGridRegistry.java b/java/server/src/org/openqa/grid/internal/BaseGridRegistry.java
@@ -18,6 +18,7 @@
 package org.openqa.grid.internal;
 
 import org.openqa.grid.web.Hub;
+import org.openqa.selenium.remote.http.ClientConfig;
 import org.openqa.selenium.remote.http.HttpClient;
 
 import java.net.URL;
@@ -62,9 +63,10 @@ public HttpClient getHttpClient(URL url) {
 
   @Override
   public HttpClient getHttpClient(URL url, int connectionTimeout, int readTimeout) {
-    return httpClientFactory.builder()
+    return httpClientFactory.createClient(
+      ClientConfig.defaultConfig()
+        .baseUrl(url)
         .connectionTimeout(Duration.ofSeconds(connectionTimeout))
-        .readTimeout(Duration.ofSeconds(readTimeout))
-        .createClient(url);
+        .readTimeout(Duration.ofSeconds(readTimeout)));
   }
 }
diff --git a/third_party/java/okhttp3/BUCK b/third_party/java/okhttp3/BUCK
@@ -8,6 +8,7 @@ prebuilt_jar(
     ],
     visibility = [
         "//java/client/src/org/openqa/selenium/remote:remote-lib",
+        "//java/client/src/org/openqa/selenium/remote/http/okhttp:",
         "//third_party/java/contrib:opentracing-okhttp3",
     ],
 )