Skip to content

Commit

Permalink
Additional closure compiler flags for ChromeDriver (#8245)
Browse files Browse the repository at this point in the history
Adding a couple of command line flags to closure compiler while
generating atoms for ChromeDriver:
* --define=goog.NATIVE_ARRAY_PROTOTYPES=false: This flag used to be
  present before migration to Bazel. Its removal caused ChromeDriver
  bugs, such as https://crbug.com/chromedriver/3422 and
  https://crbug.com/chromedriver/3439.
* --use_types_for_optimization=false: Works around closure compiler
  bugs. This used to be added by hand when the ChromeDriver team
  built atoms.

Co-authored-by: David Burns <david.burns@theautomatedtester.co.uk>
  • Loading branch information
JohnChen0 and AutomatedTester committed Apr 27, 2020
1 parent 934dfbd commit 8f672de
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions javascript/private/fragment.bzl
Expand Up @@ -74,6 +74,8 @@ def closure_fragment(
"chrome": [
"--define=goog.userAgent.ASSUME_WEBKIT=true",
"--define=goog.userAgent.product.ASSUME_CHROME=true",
"--define=goog.NATIVE_ARRAY_PROTOTYPES=false",
"--use_types_for_optimization=false",
],
"ie": [
"--define=goog.userAgent.ASSUME_IE=true",
Expand Down

0 comments on commit 8f672de

Please sign in to comment.