Skip to content

Commit

Permalink
[java] Unignoring some tests Chrome 77 passes locally
Browse files Browse the repository at this point in the history
  • Loading branch information
barancev committed Sep 15, 2019
1 parent 355dd36 commit 93e8407
Show file tree
Hide file tree
Showing 4 changed files with 0 additions and 19 deletions.
8 changes: 0 additions & 8 deletions java/client/test/org/openqa/selenium/ContentEditableTest.java
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,6 @@

import static org.assertj.core.api.Assertions.assertThat;
import static org.junit.Assume.assumeFalse;
import static org.openqa.selenium.testing.drivers.Browser.CHROME;
import static org.openqa.selenium.testing.drivers.Browser.CHROMIUMEDGE;
import static org.openqa.selenium.testing.drivers.Browser.EDGE;
import static org.openqa.selenium.testing.drivers.Browser.IE;
import static org.openqa.selenium.testing.drivers.Browser.MARIONETTE;
Expand Down Expand Up @@ -86,8 +84,6 @@ public void testShouldBeAbleToTypeIntoEmptyContentEditableElement() {
}

@Test
@NotYetImplemented(value = CHROME, reason = "https://bugs.chromium.org/p/chromedriver/issues/detail?id=2743")
@NotYetImplemented(value = CHROMIUMEDGE, reason = "https://bugs.chromium.org/p/chromedriver/issues/detail?id=2743")
@NotYetImplemented(SAFARI)
@NotYetImplemented(EDGE)
@NotYetImplemented(value = MARIONETTE, reason = "https://github.com/mozilla/geckodriver/issues/667")
Expand Down Expand Up @@ -115,8 +111,6 @@ public void testShouldBeAbleToTypeIntoTinyMCE() {
}

@Test
@NotYetImplemented(value = CHROME, reason = "https://bugs.chromium.org/p/chromedriver/issues/detail?id=2743")
@NotYetImplemented(value = CHROMIUMEDGE, reason = "https://bugs.chromium.org/p/chromedriver/issues/detail?id=2743")
@NotYetImplemented(value = IE, reason = "Prepends text")
@NotYetImplemented(value = SAFARI, reason = "Prepends text")
@NotYetImplemented(value = MARIONETTE, reason = "https://github.com/mozilla/geckodriver/issues/667")
Expand All @@ -133,8 +127,6 @@ public void testShouldAppendToTinyMCE() {
}

@Test
@NotYetImplemented(value = CHROME, reason = "https://bugs.chromium.org/p/chromedriver/issues/detail?id=2743")
@NotYetImplemented(value = CHROMIUMEDGE, reason = "https://bugs.chromium.org/p/chromedriver/issues/detail?id=2743")
@NotYetImplemented(value = MARIONETTE, reason = "Doesn't write anything")
@NotYetImplemented(value = SAFARI, reason = "Prepends text")
public void appendsTextToEndOfContentEditableWithMultipleTextNodes() {
Expand Down
6 changes: 0 additions & 6 deletions java/client/test/org/openqa/selenium/PageLoadingTest.java
Original file line number Diff line number Diff line change
Expand Up @@ -104,8 +104,6 @@ public void testNoneStrategyShouldNotWaitForPageToRefresh() {
}

@Test
@NotYetImplemented(CHROME)
@NotYetImplemented(CHROMIUMEDGE)
@NeedsLocalEnvironment
@NoDriverBeforeTest
@NoDriverAfterTest
Expand All @@ -128,8 +126,6 @@ public void testEagerStrategyShouldNotWaitForResources() {
}

@Test
@NotYetImplemented(CHROME)
@NotYetImplemented(CHROMIUMEDGE)
@NeedsLocalEnvironment
@NoDriverBeforeTest
@NoDriverAfterTest
Expand All @@ -155,8 +151,6 @@ public void testEagerStrategyShouldNotWaitForResourcesOnRefresh() {
}

@Test
@NotYetImplemented(CHROME)
@NotYetImplemented(CHROMIUMEDGE)
@NoDriverBeforeTest
@NoDriverAfterTest
public void testEagerStrategyShouldWaitForDocumentToBeLoaded() {
Expand Down
4 changes: 0 additions & 4 deletions java/client/test/org/openqa/selenium/WindowSwitchingTest.java
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,6 @@
import static org.openqa.selenium.WaitingConditions.windowHandleCountToBe;
import static org.openqa.selenium.WaitingConditions.windowHandleCountToBeGreaterThan;
import static org.openqa.selenium.support.ui.ExpectedConditions.alertIsPresent;
import static org.openqa.selenium.testing.drivers.Browser.CHROME;
import static org.openqa.selenium.testing.drivers.Browser.CHROMIUMEDGE;
import static org.openqa.selenium.testing.drivers.Browser.EDGE;
import static org.openqa.selenium.testing.drivers.Browser.FIREFOX;
import static org.openqa.selenium.testing.drivers.Browser.HTMLUNIT;
Expand Down Expand Up @@ -363,8 +361,6 @@ public void testShouldFocusOnTheTopMostFrameAfterSwitchingToAWindow() {

@NoDriverAfterTest(failedOnly = true)
@Test
@NotYetImplemented(CHROME)
@NotYetImplemented(CHROMIUMEDGE)
@NotYetImplemented(HTMLUNIT)
@NotYetImplemented(SAFARI) // actually not tested in this browser
@NotYetImplemented(OPERABLINK)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -212,7 +212,6 @@ public void testDragAndDropOnJQueryItems() {
@NotYetImplemented(SAFARI)
@Ignore(MARIONETTE)
@NotYetImplemented(EDGE)
@NotYetImplemented(CHROME)
public void canDragAnElementNotVisibleInTheCurrentViewportDueToAParentOverflow() {
driver.get(pages.dragDropOverflow);

Expand Down

0 comments on commit 93e8407

Please sign in to comment.