Fix permission denied error when removing logger output on Windows

We need to properly close logger device before attempting to remove the file
SeleniumHQ · Mar 9, 2019 · 9890e33 · 9890e33
1 parent 0a02303
commit 9890e33
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/rb/lib/selenium/webdriver/common/logger.rb b/rb/lib/selenium/webdriver/common/logger.rb
@@ -36,7 +36,9 @@ module WebDriver
     class Logger
       extend Forwardable
 
-      def_delegators :@logger, :debug, :debug?,
+      def_delegators :@logger,
+                     :close,
+                     :debug, :debug?,
                      :info, :info?,
                      :warn, :warn?,
                      :error, :error?,
@@ -68,7 +70,7 @@ def output=(io)
       # @api private
       #
       def io
-        @logger.instance_variable_get(:@logdev).instance_variable_get(:@dev)
+        @logger.instance_variable_get(:@logdev).dev
       end
 
       #

diff --git a/rb/spec/unit/selenium/webdriver/common/logger_spec.rb b/rb/spec/unit/selenium/webdriver/common/logger_spec.rb
@@ -57,6 +57,7 @@ module WebDriver
           WebDriver.logger.warn('message')
           expect(File.read('test.log')).to include('WARN Selenium message')
         ensure
+          WebDriver.logger.close
           File.delete('test.log')
         end
       end