Skip to content

Commit

Permalink
[bazel] Use Java 11 as the base JDK
Browse files Browse the repository at this point in the history
Selenium continues to target Java 8, but some functionality has to use
Java 11 in order to work properly. Until we have the equivalent of
Animal Sniffer, we'll trust to luck and good fortune that we won't
accidentally use Java 11 APIs in Java 8 classes.

This change is needed in order to allow the `java_export` rule to
generate java module-info classes automagically.
  • Loading branch information
shs96c committed Aug 24, 2019
1 parent 296a1e9 commit 9f57806
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions .bazelrc
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
try-import .bazelrc.local

# Set the default java toolchain
build --java_toolchain=@bazel_tools//tools/jdk:toolchain_java8
test --java_toolchain=@bazel_tools//tools/jdk:toolchain_java8
build --java_toolchain=@bazel_tools//tools/jdk:toolchain_java11
test --java_toolchain=@bazel_tools//tools/jdk:toolchain_java11

# We target java 8 by default
build --javacopt "-source 8"
Expand Down

0 comments on commit 9f57806

Please sign in to comment.