[rb] Don't modify income Chrome driver options

Chrome WebDriver initializer modifies incoming options for driver. Ruby's "good practices" generally boil down to not mutating data you don't own.
SeleniumHQ · Apr 1, 2019 · a2a0ebd · a2a0ebd
1 parent 98391bd
commit a2a0ebd
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/rb/lib/selenium/webdriver/chrome/service.rb b/rb/lib/selenium/webdriver/chrome/service.rb
@@ -47,6 +47,7 @@ def cannot_connect_error_text
 
         def extract_service_args(driver_opts)
           driver_args = super
+          driver_opts = driver_opts.dup
           driver_args << "--log-path=#{driver_opts.delete(:log_path)}" if driver_opts.key?(:log_path)
           driver_args << "--url-base=#{driver_opts.delete(:url_base)}" if driver_opts.key?(:url_base)
           driver_args << "--port-server=#{driver_opts.delete(:port_server)}" if driver_opts.key?(:port_server)

diff --git a/rb/spec/unit/selenium/webdriver/chrome/service_spec.rb b/rb/spec/unit/selenium/webdriver/chrome/service_spec.rb
@@ -59,7 +59,7 @@ module Chrome
           driver_opts = {port_server: '2323',
                          whitelisted_ips: ['192.168.0.1', '192.168.0.2'],
                          silent: true,
-                         log_path: '/path/to/log'}
+                         log_path: '/path/to/log'}.freeze
 
           args = ["--log-path=#{driver_opts[:log_path]}",
                   "--port-server=#{driver_opts[:port_server]}",